Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1889114 - Add 'enabled' property to pings #681

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Bug 1889114 - Add 'enabled' property to pings #681

merged 2 commits into from
Apr 15, 2024

Conversation

travis79
Copy link
Member

@travis79 travis79 commented Apr 2, 2024

This is enabled initially for Swift, Kotlin, and Rust

@travis79 travis79 force-pushed the Bug1889114 branch 2 times, most recently from 6739957 to 0c4b7f3 Compare April 2, 2024 18:44
@travis79 travis79 marked this pull request as ready for review April 5, 2024 13:40
@travis79 travis79 requested a review from chutten April 5, 2024 13:40
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with comments addressed... and with a test. Isn't there supposed to be a test? At least we probably need a ping in tests/data/pings.yaml that supplies a value for this.

glean_parser/schemas/pings.2-0-0.schema.yaml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
This is enabled initially for Swift, Kotlin, and Rust
@travis79 travis79 force-pushed the Bug1889114 branch 5 times, most recently from f90927f to 9306235 Compare April 12, 2024 13:53
@travis79
Copy link
Member Author

Test added, including pings with explicit setting of enabled to the pings.yaml file

@travis79 travis79 merged commit b9a0d43 into main Apr 15, 2024
8 checks passed
@travis79 travis79 deleted the Bug1889114 branch April 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants