Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AE-321 add support for datetime go_server.py #693

Merged
merged 7 commits into from
Apr 30, 2024
Merged

AE-321 add support for datetime go_server.py #693

merged 7 commits into from
Apr 30, 2024

Conversation

gleonard-m
Copy link
Contributor

@gleonard-m gleonard-m commented Apr 23, 2024 •
edited
Loading

Pull Request checklist

  • Quality: This PR builds and tests run cleanly

    • make test runs without emitting any warnings
    • make lint runs without emitting any errors

  • Tests: This PR includes thorough tests or an explanation of why it does not

  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one

    • Any breaking changes to language binding APIs are noted explicitly

  • AE-321 Added support for datetime in go_server.py

@gleonard-m gleonard-m marked this pull request as ready for review April 23, 2024 20:06
@gleonard-m gleonard-m marked this pull request as draft April 23, 2024 20:34
@gleonard-m gleonard-m marked this pull request as ready for review April 23, 2024 20:34
@badboy badboy requested review from badboy and akkomar April 24, 2024 07:52
travis79
travis79 reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I didn't mean to approve 😬.

@travis79 travis79 self-requested a review April 25, 2024 14:13
badboy
badboy requested changes Apr 25, 2024
View reviewed changes
glean_parser/go_server.py Outdated Show resolved Hide resolved
tests/test_go_server.py Outdated Show resolved Hide resolved
@gleonard-m gleonard-m marked this pull request as draft April 26, 2024 20:25
akkomar
akkomar previously requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@akkomar akkomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the integration test.

tests/test_go_server.py Outdated Show resolved Hide resolved
glean_parser/templates/go_server.jinja2 Outdated Show resolved Hide resolved
glean_parser/go_server.py Outdated Show resolved Hide resolved
@gleonard-m gleonard-m marked this pull request as ready for review April 29, 2024 14:17
@badboy badboy dismissed akkomar’s stale review April 30, 2024 11:28

test is there.

@badboy badboy merged commit 2283a1e into mozilla:main Apr 30, 2024
8 checks passed
@gleonard-m gleonard-m deleted the AE-321-add-support-for-datetime-go branch April 30, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy badboy approved these changes

@travis79 travis79 Awaiting requested review from travis79

@akkomar akkomar Awaiting requested review from akkomar akkomar is a code owner

@dmueller dmueller Awaiting requested review from dmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gleonard-m @badboy @dmueller @akkomar @travis79