Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Encrypt-And-MAC MAC algorithms in modern config #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtausig
Copy link

@mtausig mtausig commented Aug 9, 2024

The current version of the "Modern configuration" includes the MAC schemes

hmac-sha2-512
hmac-sha2-256
umac-128@openssh.com

Those MAC schemes use SSH's classic Encrypt-and-MAC methodology, which is well known to have cryptographic flaws (e.g., see this paper by Bellare et.al or https://moxie.org/2011/12/13/the-cryptographic-doom-principle.html).

Usage of those algorithms is also flagged by ssh-audit:

[...]
# message authentication code algorithms
(mac) hmac-sha2-512-etm@openssh.com         -- [info] available since OpenSSH 6.2
(mac) hmac-sha2-256-etm@openssh.com         -- [info] available since OpenSSH 6.2
(mac) umac-128-etm@openssh.com              -- [info] available since OpenSSH 6.2
(mac) hmac-sha2-512                         -- [warn] using encrypt-and-MAC mode
                                            `- [info] available since OpenSSH 5.9, Dropbear SSH 2013.56
(mac) hmac-sha2-256                         -- [warn] using encrypt-and-MAC mode
                                            `- [info] available since OpenSSH 5.9, Dropbear SSH 2013.56
(mac) umac-128@openssh.com                  -- [warn] using encrypt-and-MAC mode
                                            `- [info] available since OpenSSH 6.2
[...]

I would therefore suggest to remove the algorithms mentioned from the recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant