Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated command examples to represent current output #103

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Nov 15, 2021

Updated command examples to represent current output. I've run the example commands and I got a slightly different output for the jsonschema-transpiler examples. This proposed updating the README to reflect that.

Package version:

$ cargo install --list
jsonschema-transpiler v1.10.0:
    jsonschema-transpiler

Below is the output I get when running the examples:

echo $schema | jq
{
  "type": "object",
  "properties": {
    "foo": {
      "type": "boolean"
    }
  }
}
echo $schema | jsonschema-transpiler --type avro
{
  "fields": [
    {
      "default": null,
      "name": "foo",
      "type": [
        {
          "type": "null"
        },
        {
          "type": "boolean"
        }
      ]
    }
  ],
  "name": "root",
  "type": "record"
}
$ echo $schema | jsonschema-transpiler --type bigquery
[
  {
    "mode": "NULLABLE",
    "name": "foo",
    "type": "BOOL"
  }
]

@kik-kik kik-kik added the docs label Nov 15, 2021
@kik-kik kik-kik requested a review from scholtzan November 15, 2021 10:19
@kik-kik kik-kik self-assigned this Nov 15, 2021
@kik-kik
Copy link
Contributor Author

kik-kik commented Nov 18, 2021

hmm, I'm not sure what the problem with CI check is. I tried to re-run the check directly in circleci, but still seems to be stuck.

@scholtzan
Copy link
Contributor

It looks like CI completed successfully, but that status doesn't show up here: https://app.circleci.com/pipelines/github/mozilla/jsonschema-transpiler/170/workflows/fae7a692-c982-4f84-8a91-1386752bbe10/jobs/154 You can try pushing the changes again and see if that helps

@kik-kik kik-kik force-pushed the docs/examples-updated branch 2 times, most recently from e5eb2f8 to 3dd4ebf Compare November 23, 2021 11:24
@kik-kik
Copy link
Contributor Author

kik-kik commented Nov 23, 2021

ok this was driving me crazy so I tried poking around a bit. Not sure what resolved this in the end, but I tried disabling a setting for syncing status with Github and re-enabled it.

image

Not sure if that is what resolved the issue or if it's something else. But seems the check passed now. Merging the PR.

@kik-kik kik-kik merged commit b4954ac into main Nov 23, 2021
@kik-kik kik-kik deleted the docs/examples-updated branch November 23, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants