Fixes #4500, collections depreciated #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collections will be removed as of Python 3.10, Added Compatibility for versions < 3.3.
akatsoulas
approved these changes
Sep 28, 2020
akatsoulas
reviewed
Sep 28, 2020
kitsune/wiki/widgets.py
Outdated
|
|
||
| from django import forms | ||
| from django.template.loader import render_to_string | ||
|
|
||
| from kitsune.products.models import Topic | ||
| from kitsune.wiki.models import Document | ||
|
|
||
| if sys.version_info >= (3,3): |
There was a problem hiding this comment.
Could you replace the if/else statement with:
try:
from collections.abc import Iterable
except ImportError:
from collections import Iterablejust to be consistent with our imports?
|
Thanks @Metropass ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AS of Python 3.10,
collectionswill be depreciated in terms of abstract classes. Added a check if Python is >= 3.3, and importscollections.abc