-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix group profile page #5910
base: main
Are you sure you want to change the base?
Fix group profile page #5910
Conversation
Ooh, this is amazing. Thanks for working on this, Smith! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested this locally, the following buttons didn't work:
Edit group in admin
Edit group profile
Edit group leaders
When clicked, nothing happened other than the button text changed to Cancel
. It appears to have something to do with the editable
class, which activates editable.js
, which in turn, deactivates the click event's default behavior?
b14f950
to
27312ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates @smithellis. Several new observations:
- It appears that we've lost the functionality to add new members?
- I'm not sure we need the
Edit group in admin
button, since I think we can do everything on the page that we could do in the group profile admin? However, if we'd prefer to keep it, since it's currently available, it seems like it should be moved out of the group profile description section, and up into the top area? I also prefer the textEdit in admin
instead ofEdit group in admin
, just because it shorter. - Some of the buttons seem too big to me, because of the text. What do you think of shortening
Change Group Avatar
andDelete Group Avatar
to justChange Avatar
andDelete Avatar
? - The change and delete avatar buttons, since they're stacked on each other instead of side-by-side, take too much space. Could we make these side-by-side instead?
- When removing members/leaders, the text on the confirmation page is within an
h1
tag, which looks really over-sized to me.
@smithellis is this PR still active and relevant? |
42043e6
to
2743a66
Compare
2743a66
to
5d6e122
Compare
bumping this |
The Group Profile page was severely ugly/broken. I have triaged it to a usable state.