Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore GA4 logging which is used for testing on stage #6432

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

escattone
Copy link
Contributor

#6418 removed the GA4 logging infrastructure, but it's our only way to test GA4 events within the stage environment (it's disabled in all other environments), so this PR restores it.

@escattone escattone requested a review from akatsoulas January 7, 2025 22:59
Copy link
Collaborator

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like DebugView could be useful instead of logging into the console?

@escattone
Copy link
Contributor Author

Would something like DebugView could be useful instead of logging into the console?

In the past, even when using GA4's DebugView, we still found that we often needed to confirm whether or not the trackEvent call was even made by the JS, so we decided to keep GA4 event console logging on for stage only. Currently, given that the trackEvent calls have proven trustworthy, Emil just uses the GA4 console logging when QA'ing GA4 events.

@escattone escattone merged commit 29bf217 into mozilla:main Jan 8, 2025
2 checks passed
@escattone escattone deleted the restore-ga4-logging branch January 8, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants