Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate limit emails #6482

Merged
merged 2 commits into from
Feb 13, 2025
Merged

rate limit emails #6482

merged 2 commits into from
Feb 13, 2025

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Jan 31, 2025 •
edited
Loading

mozilla/sumo#1993

Do not merge this until after we discover more from #6480.

@escattone escattone force-pushed the rate-limit-emails branch 2 times, most recently from 62b725a to 0ca1e04 Compare February 3, 2025 17:39
@escattone escattone marked this pull request as ready for review February 3, 2025 18:57
@escattone escattone requested a review from akatsoulas February 3, 2025 18:57
@escattone escattone force-pushed the rate-limit-emails branch 2 times, most recently from 7ce739a to 78c525a Compare February 10, 2025 17:42
akatsoulas
akatsoulas approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! 🚀

nit: I wonder if it makes sense to add some jitter in the wait function to distribute the load and avoid multiple processes running at the same time. Up to your discretion.

@escattone escattone merged commit 0356cc0 into mozilla:main Feb 13, 2025
2 checks passed
@escattone escattone deleted the rate-limit-emails branch February 13, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akatsoulas akatsoulas akatsoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escattone @akatsoulas