Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 - Long user watch list causes page loading issues #6514

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

smithellis
Copy link
Contributor

  • Added pagination to view and template

* Added pagination to view and template
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

Pagination depends on a consistent ordering of the individual items, but since the ordering is currently by content_type only, it's possible that the individual items aren't consistently ordered -- since for example a user could be watching hundreds of the question content type and there would be no consistent ordering of the hundreds of individual questions. I would recommend changing the order_by("content_type") to order_by("content_type", "id") so that ordering is guaranteed at the level of individual items.

@akatsoulas akatsoulas merged commit 9baae51 into mozilla:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants