-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
aec318e
to
49b29dd
Compare
@toolness R? |
Awesome thanks Ali! Hmm, I am seeing the sourcemaps for the CSS/LESS, but not for the JS... When I intentionally add an exception in the code, for instance, it just shows me Loading |
Oh, so I'm now noticing that when I run And when I run So I guess things need to change so that the bundle is uglified for production, and source maps are generated for development? This is getting a little confusing--I'm starting to think we need a test suite for our own build system! 😅 |
var outputPath = path.join(__dirname, COMPILED_DIR, 'js'); | ||
fs.removeSync(outputPath); | ||
var outputName = 'bundle.js'; | ||
var config = require('./webpack.config'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, since we are essentially dynamically creating our webpack config, perhaps we should just do away with webpack.config.js
entirely?
So this PR is doing lots of stuff that I'm confused about... I think it might be better to split this into two different objectives:
Is it ok if I take the very basics of what you've done to address (1) and issue a really simple separate PR to address them? Then we can address (2) anytime before launch. |
Closing this in favour of #147 |
This patch should fix the issue we are having in #135 as well.
Right now by default when you run
gulp dev
ornpm start
it shouldn't uglify the JS for you since it's for development. The downside here as we know it will slow down the browser load time, but obviously it will increase our productivity significantly.We still have the useful webpack plugin enabled when you run
gulp
only which should be the build step for us on production.I'm still having trouble getting
LESS
to work on Firefox for some reason but other than that this is in a good state at the moment.