Send with retry for redis.rpush #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We might need to re-connect on failure, rather than just retrying. What was the error message exactly? |
Contributor
Author
This is an older log with aioredis, but it was almost identical with redis-py, https://paste.mozilla.org/h8jpZrcd |
Collaborator
|
Maybe there is a way with the library to enable auto-reconnection? If not, we'd have to build a wrapper around it, or another option could be to create a new connection for every rpush (but that might slow things down). |
abpostelnicu
force-pushed
the
master
branch
4 times, most recently
from
9c1f6d6 to
8b2f506
Compare
marco-c
reviewed
Dec 7, 2022
marco-c
reviewed
Dec 7, 2022
marco-c
reviewed
Dec 12, 2022
marco-c
reviewed
Dec 12, 2022
marco-c
reviewed
Dec 12, 2022
marco-c
reviewed
Dec 12, 2022
marco-c
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.