Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Make the EDN parser support the correct tokens for Keyword and Symbol #154

Closed
joewalker opened this issue Jan 9, 2017 · 4 comments
Closed

Make the EDN parser support the correct tokens for Keyword and Symbol #154

joewalker opened this issue Jan 9, 2017 · 4 comments
Assignees
@rnewman

Comments

@joewalker
Copy link
Member

Useful links:
#149 (comment)
https://github.com/joewalker/mentat/blob/f609f4f60c3845811a74c40288872d66611b42c6/edn/src/edn.rustpeg#L54
https://github.com/edn-format/edn
@joewalker joewalker mentioned this issue Jan 9, 2017
Closed
@rnewman
Copy link
Collaborator

rnewman commented Jan 9, 2017

Depends on #139, which I should be landing momentarily.

@joewalker
Copy link
Member Author

Also depends on #149 which needs rebasing before it can land

@rnewman rnewman self-assigned this Jan 11, 2017
@rnewman
Copy link
Collaborator

rnewman commented Jan 11, 2017

I'm about 80% through doing this for Keyword.

rnewman added a commit that referenced this issue Jan 12, 2017
@rnewman
Read EDN keywords and symbols as rich types. Fixes #154. r=nalexander
7ff0acc
@rnewman
Copy link
Collaborator

rnewman commented Jan 12, 2017

Fixed by #163. @joewalker, if you get to this before @ncalexan does, feel free to steal the second rubberstamp review!

victorporof pushed a commit that referenced this issue Feb 2, 2017
@rnewman
Read EDN keywords and symbols as rich types. Fixes #154. r=nalexander
9e1acd1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rnewman rnewman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joewalker @rnewman