This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Generic automation images #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncalexan
force-pushed
the
generic-automation-images
branch
from
72beda4 to
7bc10d7
Compare
…l Android standalone toolchains. This is ready for Android Rust-y components: it no longer references Mentat. The standalone toolchains are installed into $ANDROID_NDK_TOOLCHAIN_DIR/arch-$ANDROID_NDK_API_VERSION.
Docker is directory oriented so we have to play along.
ncalexan
force-pushed
the
generic-automation-images
branch
from
7bc10d7 to
b5d0e12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the Mentat-specific parts of our Docker image out of the Android NDK + Rust parts of the Docker image. In the process, it moves the ARM Rust architecture from
arm-linux-androideabitoarmv7-linux-androideabi, which is considered more modern and is what the FxA Rust client is targeting. It also puts the Android NDK standalone toolchains in a global location, and changes the expected names. This all requires commensurate changes in therust-android-gradleplugin; hence the version bump.