This repository was archived by the owner on Mar 29, 2019. It is now read-only.
Consideration of CIDR Network in Minion#156
Open
Wawki wants to merge 3 commits intomozilla:masterfrom
Open
Conversation
… enter CIDR networks and not IP addresses like 127.0.0.1
Contributor
|
Okay, CC'ing @glestel into this conversation as well. Couple things about this:
|
Contributor
Author
|
As @glestel said, for IPv6 it was developed later, I'll try to link that here. For the full ipv6 support and the site verification, we'll have to think more about it, but in fact it's a problem. |
Contributor
|
@Wawki: When you make PRs, make sure to always sync from upstream before you apply your changes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not possible to add CIDR Network in Minion. It was missing, for example, for the NMAP plugin.
See this pull request : mozilla/minion-backend#321