Skip to content
This repository was archived by the owner on Mar 29, 2019. It is now read-only.

Consideration of CIDR Network in Minion#156

Open
Wawki wants to merge 3 commits intomozilla:masterfrom
Wawki:cidr_network
Open

Consideration of CIDR Network in Minion#156
Wawki wants to merge 3 commits intomozilla:masterfrom
Wawki:cidr_network

Conversation

@Wawki
Copy link
Contributor

@Wawki Wawki commented Jun 12, 2015

It was not possible to add CIDR Network in Minion. It was missing, for example, for the NMAP plugin.

See this pull request : mozilla/minion-backend#321

@april
Copy link
Contributor

april commented Jun 12, 2015

Okay, CC'ing @glestel into this conversation as well.

Couple things about this:

  • This won't work with IPv6; if we're going to merge any IP range scanning stuff, I'd like to see it work with IPv6. Maybe not now, but it needs to get done.
  • When we add site verification (eventually), it's going to be extremely difficult/impossible to verify sites. For that reason, we'll need to have an easy way to disable IP address based sites in (at least Mozilla's) production.

@Wawki
Copy link
Contributor Author

Wawki commented Jun 15, 2015

As @glestel said, for IPv6 it was developed later, I'll try to link that here.

For the full ipv6 support and the site verification, we'll have to think more about it, but in fact it's a problem.

@april
Copy link
Contributor

april commented Jun 19, 2015

@Wawki: When you make PRs, make sure to always sync from upstream before you apply your changes. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants