Path improvements for use in Pontoon #22
Conversation
| but `ref_root` itself contains files with extensions that appear localizable, | ||
| it is used as the reference directory. | ||
|
|
||
| The default `source_locale` is `['en-US', 'en']`, |
There was a problem hiding this comment.
What happens with "templates"?
There was a problem hiding this comment.
Not treated as anything special. From Pontoon we call this with ref_root set to the source repo root, which doesn't need to have any special name in order to fall back to using the repo root as the reference root.
There was a problem hiding this comment.
How is it going to detect that https://github.com/mozilla/addons-server/tree/master/locale/templates is the source locale folder, and not https://github.com/mozilla/addons-server/tree/master/locale/en_US?
There was a problem hiding this comment.
At least for now, we'll need to call this from Pontoon with source_locale=["templates", "en-US", "en"] to keep its behaviour consistent.
There was a problem hiding this comment.
Meh, I completely missed ref_paths was a function parameter.
|
I think this batch is complete for now, and I could roll out a new release once this lands. Further iteration may of course be needed later. |
A collection of fixes to paths required by Pontoon (mozilla/pontoon#3312).