Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Migrate Mozilla Locamotion ExternalAccounts to new identifier. #1219

Merged
merged 1 commit into from
Aug 7, 2015

Conversation

johngian
Copy link
Contributor

@johngian johngian commented Aug 7, 2015

No description provided.

@johngian
Copy link
Contributor Author

johngian commented Aug 7, 2015

Reproduced/verified locally:

  • Checkout to version 2015-7.1
  • Add a LOCOMOTION ExternalAccount to your profile
  • Checkout to master
  • Access your profile page
  • Error gets raised
  • Checkout to this PR
  • Run migrations
  • Access your profile page
  • No error gets raised

@akatsoulas r?


class Migration(DataMigration):

def forwards(self, orm):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a couple of docstrings in forward and maybe backward methods.

@johngian
Copy link
Contributor Author

johngian commented Aug 7, 2015

@akatsoulas PR updated

@akatsoulas
Copy link
Contributor

Tested locally and looks good. r+ 👍

johngian added a commit that referenced this pull request Aug 7, 2015
Migrate Mozilla Locamotion ExternalAccounts to new identifier.
@johngian johngian merged commit 9af967f into mozilla:master Aug 7, 2015
@johngian johngian deleted the 2015-8.1-hotfix branch August 7, 2015 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants