Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Fix login_failure regression #1245

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Fix login_failure regression #1245

merged 1 commit into from
Sep 17, 2015

Conversation

johngian
Copy link
Contributor

  • Introduced in django-browserid upgrade from v0.10.1 to v1
  • Different definition of def login_failure()

@johngian
Copy link
Contributor Author

@akatsoulas r?

Verification steps:

  • Checkout to master
  • Edit vendor-local/src/django-browserid/django_browserid/views.py
    • To reproduce it change def post to return self.login_failure() always
  • Try to login
    • 500 server error should be raised
  • Checkout to this PR
  • Try to login
    • You should be redirected to homepage

@akatsoulas
Copy link
Contributor

r+

@johngian
[Fix bug 1205664] Fix login_failure regression
d63c25f 
* Introduced in django-browserid upgrade from v0.10.1 to v1
* Different definition of `def login_failure()`
johngian added a commit that referenced this pull request Sep 17, 2015
@johngian
Merge pull request #1245 from johngian/1205664
771ba2b 
Fix login_failure regression
@johngian johngian merged commit 771ba2b into mozilla:master Sep 17, 2015
@johngian johngian deleted the 1205664 branch September 17, 2015 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johngian @akatsoulas