Don't fail when the wave atom contains different atoms than esds #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get this merged and release an updated crate to crates.io? |
|
Sorry for the delay, I'll take a look at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
waveatom parsing such that it doesn't fail when that atom contains unknown (not implemented) boxes.Example file where this happens: https://drive.google.com/file/d/1NbX5QlSR8BLuHK2uj0lm14yJ0DJ3jT4H/view?usp=sharing
Instead of failing to parse the entire file, just skip that box and leave
codec_specificasNone