ci: Fix the fuzz targets (#1972)

* ci: Fix the fuzz targets

And check them during CI, so they keep building.

* Fix

* Fix

* Add cargo-fuzz

* Fix the fuzzers

* Fix two clippy nightly things while I'm here

.github/actions/rust/action.yml

@@ -24,7 +24,9 @@ runs:
 
     - name: Install Rust tools
       shell: bash
-      run: cargo +${{ inputs.version }} quickinstall --no-binstall --no-fallback cargo-llvm-cov cargo-nextest flamegraph cargo-hack cargo-mutants hyperfine
+      run: |
+        cargo +${{ inputs.version }} quickinstall --no-binstall --no-fallback \
+          cargo-llvm-cov cargo-nextest flamegraph cargo-hack cargo-mutants hyperfine cargo-fuzz
 
     # sccache slows CI down, so we leave it disabled.
     # Leaving the steps below commented out, so we can re-evaluate enabling it later.

.github/workflows/check.yml

@@ -143,6 +143,10 @@ jobs:
           # hidden given that a plain cargo clippy combines all features of the
           # workspace. See e.g. https://github.com/mozilla/neqo/pull/1695.
           cargo +${{ matrix.rust-toolchain }} hack clippy --all-targets --feature-powerset --exclude-features gecko -- -D warnings || ${{ matrix.rust-toolchain == 'nightly' }}
+          # Check that the fuzz targets also build
+          if [ ${{ matrix.rust-toolchain }} == 'nightly' ]; then
+            cargo +${{ matrix.rust-toolchain }} fuzz check
+          fi
         if: success() || failure()
 
       - name: Check rustdoc links

fuzz/fuzz_targets/client_initial.rs

@@ -6,7 +6,7 @@ use libfuzzer_sys::fuzz_target;
 #[cfg(all(fuzzing, not(windows)))]
 fuzz_target!(|data: &[u8]| {
     use neqo_common::{Datagram, Encoder, Role};
-    use neqo_transport::Version;
+    use neqo_transport::{packet::MIN_INITIAL_PACKET_SIZE, Version};
     use test_fixture::{
         default_client, default_server,
         header_protection::{

fuzz/fuzz_targets/server_initial.rs

@@ -6,7 +6,7 @@ use libfuzzer_sys::fuzz_target;
 #[cfg(all(fuzzing, not(windows)))]
 fuzz_target!(|data: &[u8]| {
     use neqo_common::{Datagram, Encoder, Role};
-    use neqo_transport::Version;
+    use neqo_transport::{packet::MIN_INITIAL_PACKET_SIZE, Version};
     use test_fixture::{
         default_client, default_server,
         header_protection::{

neqo-http3/src/connection_client.rs

@@ -973,7 +973,7 @@ impl Http3Client {
             }
             Err(e) => {
                 qinfo!([self], "Connection error: {}.", e);
-                self.close(now, e.code(), &format!("{e}"));
+                self.close(now, e.code(), format!("{e}"));
                 true
             }
             _ => false,

neqo-http3/src/connection_server.rs

@@ -255,7 +255,7 @@ impl Http3ServerHandler {
 
     fn close(&mut self, conn: &mut Connection, now: Instant, err: &Error) {
         qinfo!([self], "Connection error: {}.", err);
-        conn.close(now, err.code(), &format!("{err}"));
+        conn.close(now, err.code(), format!("{err}"));
         self.base_handler.close(err.code());
         self.events
             .connection_state_change(self.base_handler.state());