Crypto error handling #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrover
previously requested changes
Aug 13, 2019
This was referenced Aug 14, 2019
Closes #166.
This attempts to use TryFrom more aggressively so that we have a clearer indication of the expected type. I left a few try_into instances around where the type was clear from context and the extra type information would have polluted things too much.
martinthomson
force-pushed
the
crypto-error-handling
branch
from
2bb1116
to
456c558
Compare
|
I've rebased this and done some more serious refactoring of the error handling pieces. I've removed a couple of files in the process, which were created before I understood the whole conversion piece better. |
|
looks good, just needs conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex pointed out a few potential bugs in the code. This fixes the integer overflow and the UAF, but in doing the latter I decided that it would be better to centralize the error handling into the experimental API macro. That allows the wrapper to report errors with CString::new() rather than just calling panic!.
Fixes #145.