Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: print current StateSignaling variant in debug_assert #1783

Merged
merged 2 commits into from
Apr 2, 2024

Commits on Apr 1, 2024

  1. refactor: print current StateSignaling variant in debug_assert

    CI paniced in `StateSignaling::handshake_done`. Though failure hasn't been
    reproducible locally. To ease debugging future CI failures, print the current
    state on panic.
    
    ```
    thread 'idle_timeout_crazy_rtt' panicked at neqo-transport\src\connection\state.rs:212:13:
    StateSignaling must be in Idle state.
    stack backtrace:
       0: std::panicking::begin_panic_handler
                 at /rustc/8df7e723ea729a7f917501cc2d91d640b7021373/library\std\src\panicking.rs:646
       1: core::panicking::panic_fmt
                 at /rustc/8df7e723ea729a7f917501cc2d91d640b7021373/library\core\src\panicking.rs:72
       2: enum2$<neqo_transport::connection::state::StateSignaling>::handshake_done
                 at .\src\connection\state.rs:212
       3: neqo_transport::connection::Connection::handle_lost_packets
                 at .\src\connection\mod.rs:2847
       4: neqo_transport::connection::Connection::process_timer
                 at .\src\connection\mod.rs:966
       5: neqo_transport::connection::Connection::process_output
                 at .\src\connection\mod.rs:1085
       6: neqo_transport::connection::Connection::process
                 at .\src\connection\mod.rs:1108
       7: test_fixture::sim::connection::impl$1::process
                 at D:\a\neqo\neqo\test-fixture\src\sim\connection.rs:146
       8: test_fixture::sim::Simulator::process_loop
                 at D:\a\neqo\neqo\test-fixture\src\sim\mod.rs:193
       9: test_fixture::sim::ReadySimulator::run
                 at D:\a\neqo\neqo\test-fixture\src\sim\mod.rs:284
      10: test_fixture::sim::Simulator::run
                 at D:\a\neqo\neqo\test-fixture\src\sim\mod.rs:265
      11: network::idle_timeout_crazy_rtt
                 at D:\a\neqo\neqo\test-fixture\src\sim\mod.rs:69
      12: network::idle_timeout_crazy_rtt::closure$0
                 at D:\a\neqo\neqo\test-fixture\src\sim\mod.rs:58
      13: core::ops::function::FnOnce::call_once<network::idle_timeout_crazy_rtt::closure_env$0,tuple$<> >
                 at /rustc/8df7e723ea729a7f917501cc2d91d640b7021373\library\core\src\ops\function.rs:250
      14: core::ops::function::FnOnce::call_once
                 at /rustc/8df7e723ea729a7f917501cc2d91d640b7021373/library\core\src\ops\function.rs:250
    note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    ```
    
    https://github.com/mozilla/neqo/actions/runs/8496770595/job/23274538553
    mxinden committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    b0d989b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. clippy

    mxinden committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    20bbc85 View commit details
    Browse the repository at this point in the history