Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Clean up tmp directory on script exit #1810

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (7ff76c7) to head (1fd0ff7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1810   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files         117      117           
  Lines       36339    36339           
=======================================
  Hits        33843    33843           
  Misses       2496     2496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert added this pull request to the merge queue Apr 9, 2024
Merged via the queue into mozilla:main with commit 329af2f Apr 9, 2024
15 checks passed
@larseggert larseggert deleted the test-trap branch April 9, 2024 14:30
Copy link

github-actions bot commented Apr 9, 2024

Benchmark results

Performance differences relative to 7ff76c7.

  • drain a timer quickly time: [359.48 ns 366.74 ns 373.38 ns]
    change: [-12.346% -6.3109% -2.2551%] (p = 0.01 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 1+1 entries
    time: [193.67 ns 194.07 ns 194.50 ns]
    change: [-0.8263% -0.3493% +0.1185%] (p = 0.15 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [238.80 ns 239.44 ns 240.12 ns]
    change: [-0.1332% +0.3344% +0.8708%] (p = 0.21 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [237.58 ns 238.58 ns 239.69 ns]
    change: [-0.3378% +0.2685% +0.8988%] (p = 0.42 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [220.49 ns 225.61 ns 237.30 ns]
    change: [-0.1302% +3.6950% +10.813%] (p = 0.25 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [118.26 ms 118.40 ms 118.61 ms]
    change: [-0.1827% +0.0040% +0.2346%] (p = 0.97 > 0.05)
    No change in performance detected.

  • transfer/Run multiple transfers with varying seeds
    time: [119.83 ms 120.14 ms 120.46 ms]
    thrpt: [33.205 MiB/s 33.295 MiB/s 33.382 MiB/s]
    change:
    time: [-0.4354% -0.0730% +0.2922%] (p = 0.70 > 0.05)
    thrpt: [-0.2914% +0.0731% +0.4373%]
    No change in performance detected.

  • transfer/Run multiple transfers with the same seed
    time: [120.63 ms 120.83 ms 121.03 ms]
    thrpt: [33.049 MiB/s 33.105 MiB/s 33.159 MiB/s]
    change:
    time: [-0.2180% +0.0143% +0.2408%] (p = 0.91 > 0.05)
    thrpt: [-0.2402% -0.0143% +0.2185%]
    No change in performance detected.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1233 s 1.1343 s 1.1487 s]
    thrpt: [87.058 MiB/s 88.161 MiB/s 89.023 MiB/s]
    change:
    time: [-0.0892% +1.5182% +3.1509%] (p = 0.09 > 0.05)
    thrpt: [-3.0547% -1.4955% +0.0893%]
    No change in performance detected.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [429.01 ms 431.12 ms 433.23 ms]
    thrpt: [23.082 Kelem/s 23.196 Kelem/s 23.310 Kelem/s]
    change:
    time: [-0.7928% -0.0885% +0.6568%] (p = 0.81 > 0.05)
    thrpt: [-0.6525% +0.0886% +0.7991%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [51.302 ms 51.805 ms 52.291 ms]
    thrpt: [19.124 elem/s 19.303 elem/s 19.492 elem/s]
    change:
    time: [-0.0209% +1.1820% +2.3755%] (p = 0.06 > 0.05)
    thrpt: [-2.3204% -1.1682% +0.0209%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 838.9 ± 314.9 428.8 1312.1 1.00
neqo msquic reno on 1028.8 ± 209.6 787.4 1360.3 1.00
neqo msquic reno 949.9 ± 306.2 766.8 1554.2 1.00
neqo msquic cubic on 894.2 ± 180.7 753.3 1312.8 1.00
neqo msquic cubic 857.9 ± 147.1 756.9 1196.0 1.00
msquic neqo reno on 4471.0 ± 337.7 4185.1 5136.9 1.00
msquic neqo reno 4438.2 ± 226.2 4145.9 4865.1 1.00
msquic neqo cubic on 4440.5 ± 137.9 4272.7 4642.5 1.00
msquic neqo cubic 4504.9 ± 271.8 4190.7 5112.3 1.00
neqo neqo reno on 3661.4 ± 168.1 3402.1 3972.8 1.00
neqo neqo reno 3401.7 ± 102.9 3244.7 3582.2 1.00
neqo neqo cubic on 4328.9 ± 259.8 4052.5 4940.4 1.00
neqo neqo cubic 4279.4 ± 148.2 4014.7 4484.4 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants