Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump martenseemann/quic-network-simulator-endpoint from 1259654 to 91b21d4 in /qns #1896

Merged
merged 1 commit into from
May 13, 2024
Merged

build(deps): bump martenseemann/quic-network-simulator-endpoint from 1259654 to 91b21d4 in /qns #1896

merged 1 commit into from
May 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2024

Bumps martenseemann/quic-network-simulator-endpoint from 1259654 to 91b21d4.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps): bump martenseemann/quic-network-simulator-endpoint in /qns
4b2dc34 
Bumps martenseemann/quic-network-simulator-endpoint from `1259654` to `91b21d4`.

---
updated-dependencies:
- dependency-name: martenseemann/quic-network-simulator-endpoint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels May 13, 2024
@github-actions GitHub Actions
Copy link

Failed Interop Tests

None 🎉

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@github-actions GitHub Actions
Copy link

Benchmark results

Performance differences relative to 3015218.

  • drain a timer quickly time: [322.91 ns 330.04 ns 336.74 ns]
    change: [+2.5458% +4.5575% +6.7202%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 1+1 entries
    time: [212.73 ns 213.20 ns 213.70 ns]
    change: [+8.9363% +9.3203% +9.6916%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 3+1 entries
    time: [257.20 ns 257.86 ns 258.58 ns]
    change: [+6.6549% +7.4632% +8.3823%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [256.04 ns 257.09 ns 258.27 ns]
    change: [+5.8708% +6.7058% +7.5584%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 1000+1 entries
    time: [236.00 ns 236.23 ns 236.51 ns]
    change: [+7.8456% +8.6220% +9.3927%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • RxStreamOrderer::inbound_frame()
    time: [119.50 ms 119.55 ms 119.60 ms]
    change: [+0.6668% +0.7468% +0.8315%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [117.87 ms 118.16 ms 118.45 ms]
    thrpt: [33.768 MiB/s 33.852 MiB/s 33.935 MiB/s]
    change:
    time: [-2.1639% -1.8438% -1.4947%] (p = 0.00 < 0.05)
    thrpt: [+1.5174% +1.8785% +2.2117%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [118.07 ms 118.31 ms 118.58 ms]
    thrpt: [33.734 MiB/s 33.808 MiB/s 33.880 MiB/s]
    change:
    time: [-2.1184% -1.8072% -1.4963%] (p = 0.00 < 0.05)
    thrpt: [+1.5190% +1.8405% +2.1642%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1175 s 1.1204 s 1.1234 s]
    thrpt: [89.014 MiB/s 89.255 MiB/s 89.485 MiB/s]
    change:
    time: [-2.0810% -1.7113% -1.3055%] (p = 0.00 < 0.05)
    thrpt: [+1.3227% +1.7411% +2.1252%]
    💚 Performance has improved.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [425.18 ms 427.62 ms 430.07 ms]
    thrpt: [23.252 Kelem/s 23.385 Kelem/s 23.519 Kelem/s]
    change:
    time: [-1.3874% -0.6164% +0.0722%] (p = 0.11 > 0.05)
    thrpt: [-0.0721% +0.6202% +1.4069%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [49.778 ms 50.006 ms 50.225 ms]
    thrpt: [19.910 elem/s 19.998 elem/s 20.089 elem/s]
    change:
    time: [-0.1018% +0.4175% +0.8807%] (p = 0.10 > 0.05)
    thrpt: [-0.8730% -0.4158% +0.1019%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 420.6 ± 50.5 359.5 530.4 1.00
neqo msquic reno on 764.5 ± 14.0 736.1 791.9 1.00
neqo msquic reno 776.0 ± 16.8 755.0 806.9 1.00
neqo msquic cubic on 793.9 ± 64.9 743.6 970.0 1.00
neqo msquic cubic 783.0 ± 31.6 744.0 841.9 1.00
msquic neqo reno on 5277.6 ± 198.6 4958.1 5569.5 1.00
msquic neqo reno 5283.1 ± 211.8 4896.2 5604.0 1.00
msquic neqo cubic on 5160.2 ± 184.3 4905.8 5428.1 1.00
msquic neqo cubic 5073.6 ± 182.1 4781.3 5333.6 1.00
neqo neqo reno on 4337.5 ± 257.9 3883.5 4684.0 1.00
neqo neqo reno 3798.8 ± 213.9 3428.9 4045.5 1.00
neqo neqo cubic on 4761.7 ± 324.8 3987.1 5070.3 1.00
neqo neqo cubic 4967.1 ± 157.3 4725.4 5166.9 1.00

⬇️ Download logs

@larseggert larseggert enabled auto-merge May 13, 2024 09:46
@github-actions GitHub Actions
Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert larseggert added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 520bfb0 May 13, 2024
55 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/martenseemann/quic-network-simulator-endpoint-91b21d42e23023e08c5ed63c1c08ec24d058c4b30edd52aa3bd74bee87096a5b branch May 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larseggert larseggert larseggert approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@larseggert