feat(bin): enable Firefox to use quinn-udp through neqo-udp #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 94.79% 94.78% -0.02%
==========================================
Files 110 111 +1
Lines 35722 35896 +174
==========================================
+ Hits 33864 34024 +160
- Misses 1858 1872 +14 ☔ View full report in Codecov by Sentry. |
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
KershawChang
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Looks good to me.
@martinthomson , @larseggert , could you also review this PR?
Thanks.
larseggert
reviewed
Jun 18, 2024
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jun 25, 2024
mozilla#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of mozilla#1568. This is partially motivated by mozilla#1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in mozilla#1920 (comment).
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Jun 25, 2024
mozilla#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of mozilla#1568. This is partially motivated by mozilla#1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in mozilla#1920 (comment).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
#1568 introduced TTL information to datagrams. On the input path it would take the ttl information, but not act on it. On the output path it would set only "the default TTL on many OSes". https://github.com/mozilla/neqo/blob/66504908e5fa070a8a5fa67d8b5a201d2c9a5cc5/neqo-transport/src/path.rs#L576 This commit removes the ttl information from `Datagram`, thus reverting a subset of #1568. This is partially motivated by #1920, introducing `quinn-udp` as the IO library of choice, which does not support reading and writing TTL. See also discussion in #1920 (comment).
larseggert
approved these changes
Jul 1, 2024
auto-merge was automatically disabled
July 2, 2024 09:58
Head branch was pushed to by a user without write access
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neqo-udpcrate. Firefox does not needneqo-server,neqo-client, nor any of its dependencies. A new crate enforces none of this leaking into Firefox.Socketto be used both withtokio::net::UdpSocket(forneqo-client,neqo-server, mozilla-central'shttp3server) andstd::os::fd::BorrowedFd(std::os::windows::io::BorrowedSocketon Windows). The latter allowsneqo-glueto useneqo-udpwith a UDP socket managed byNSPR.