refactor(transport/recovery): remove needless mut
#1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
approved these changes
Jun 17, 2024
I am surprised as well. Tried to figure out where |
mxinden
changed the title
mutmut
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 110 110
Lines 35792 35792
=======================================
Hits 33938 33938
Misses 1854 1854 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 6664452. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [196.94 ns 197.41 ns 197.91 ns]
change: [-0.1377% +0.2602% +0.6748%] (p = 0.21 > 0.05)
Found 18 outliers among 100 measurements (18.00%)
7 (7.00%) high mild
11 (11.00%) high severecoalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [238.24 ns 238.79 ns 239.38 ns]
change: [-0.3351% +0.1358% +0.6343%] (p = 0.59 > 0.05)
Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) low mild
2 (2.00%) high mild
11 (11.00%) high severecoalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [237.44 ns 238.20 ns 239.10 ns]
change: [+0.0746% +0.5662% +1.1094%] (p = 0.03 < 0.05)
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) low mild
7 (7.00%) high severecoalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [217.15 ns 217.43 ns 217.76 ns]
change: [-4.4447% -1.1277% +0.9330%] (p = 0.61 > 0.05)
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) high mild
8 (8.00%) high severeRxStreamOrderer::inbound_frame(): Change within noise threshold. time: [119.61 ms 119.71 ms 119.81 ms]
change: [+0.3259% +0.4394% +0.5526%] (p = 0.00 < 0.05)
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mildtransfer/Run multiple transfers with varying seeds: Change within noise threshold. time: [120.25 ms 120.56 ms 120.87 ms]
thrpt: [33.093 MiB/s 33.179 MiB/s 33.263 MiB/s]
change:
time: [+0.1124% +0.4875% +0.8214%] (p = 0.01 < 0.05)
thrpt: [-0.8147% -0.4852% -0.1123%]
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high severetransfer/Run multiple transfers with the same seed: Change within noise threshold. time: [120.66 ms 120.85 ms 121.05 ms]
thrpt: [33.043 MiB/s 33.099 MiB/s 33.150 MiB/s]
change:
time: [+0.2663% +0.4758% +0.6839%] (p = 0.00 < 0.05)
thrpt: [-0.6793% -0.4735% -0.2656%]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [1.0562 s 1.0825 s 1.1156 s]
thrpt: [89.639 MiB/s 92.379 MiB/s 94.683 MiB/s]
change:
time: [-8.1243% -4.9535% -1.3187%] (p = 0.02 < 0.05)
thrpt: [+1.3363% +5.2117% +8.8427%]
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high severe1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [387.37 ms 390.91 ms 394.46 ms]
thrpt: [25.351 Kelem/s 25.581 Kelem/s 25.815 Kelem/s]
change:
time: [-1.8699% -0.6289% +0.4875%] (p = 0.30 > 0.05)
thrpt: [-0.4851% +0.6329% +1.9056%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.