Fix up the Taskcluster / Taskgraph configuration #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we'd like to keep the CI configuration files hidden in this repo, I came across a bug in Taskgraph triggered by changing the root Taskgraph directory to a non standard location. This bug will require a new release to fix (and I suspect there will be other bugs revealed afterwards). In the meantime, we can move the files to the standard place while this is fixed. I filed taskcluster/taskgraph#522 to track the fix.
ahal
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 110 110
Lines 35792 35792
=======================================
Hits 33938 33938
Misses 1854 1854 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 95104fe. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [200.17 ns 200.60 ns 201.06 ns]
change: [+1.7223% +2.1393% +2.5610%] (p = 0.00 < 0.05)
Found 13 outliers among 100 measurements (13.00%)
11 (11.00%) high mild
2 (2.00%) high severecoalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [242.98 ns 243.57 ns 244.21 ns]
change: [+1.7488% +2.9055% +4.8544%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)
3 (3.00%) high mild
13 (13.00%) high severecoalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [243.77 ns 244.51 ns 245.41 ns]
change: [+1.9816% +2.4760% +3.0483%] (p = 0.00 < 0.05)
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low mild
7 (7.00%) high severecoalesce_acked_from_zero 1000+1 entries: 💔 Performance has regressed. time: [222.12 ns 222.32 ns 222.53 ns]
change: [+2.0385% +2.7522% +3.4106%] (p = 0.00 < 0.05)
Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severeRxStreamOrderer::inbound_frame(): Change within noise threshold. time: [118.34 ms 118.44 ms 118.55 ms]
change: [+0.1341% +0.2594% +0.3898%] (p = 0.00 < 0.05)
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/Run multiple transfers with varying seeds: No change in performance detected. time: [119.60 ms 119.87 ms 120.14 ms]
thrpt: [33.294 MiB/s 33.370 MiB/s 33.445 MiB/s]
change:
time: [-0.3503% -0.0367% +0.2876%] (p = 0.83 > 0.05)
thrpt: [-0.2868% +0.0367% +0.3515%]
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mildtransfer/Run multiple transfers with the same seed: Change within noise threshold. time: [120.06 ms 120.24 ms 120.45 ms]
thrpt: [33.209 MiB/s 33.265 MiB/s 33.318 MiB/s]
change:
time: [+0.1348% +0.3631% +0.5966%] (p = 0.00 < 0.05)
thrpt: [-0.5931% -0.3618% -0.1346%]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [1.0846 s 1.1095 s 1.1376 s]
thrpt: [87.908 MiB/s 90.128 MiB/s 92.197 MiB/s]
change:
time: [-7.8217% -4.5744% -1.0492%] (p = 0.03 < 0.05)
thrpt: [+1.0603% +4.7937% +8.4854%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [41.710 ms 41.794 ms 41.883 ms]
thrpt: [23.876 elem/s 23.927 elem/s 23.975 elem/s]
change:
time: [-0.8813% -0.5371% -0.2094%] (p = 0.00 < 0.05)
thrpt: [+0.2098% +0.5400% +0.8891%]
Found 26 outliers among 100 measurements (26.00%)
21 (21.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severeClient/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Jul 1, 2024
This was referenced Jul 1, 2024
|
@ahal we're still seeing various failures after merging this PR, e.g. |
larseggert
added a commit
to larseggert/neqo
that referenced
this pull request
Jul 2, 2024
Until someone who understands it can debug. mozilla#1935 didn't fix it.
larseggert
added a commit
that referenced
this pull request
Jul 2, 2024
Until someone who understands it can debug. #1935 didn't fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you'd like to hide the Taskgraph configuration files in
.taskgraph, but I came across some bugs when putting this in a non-standard location. I filed taskcluster/taskgraph#522 but I suggest we move it back totaskclusterin the meantime.Alternatively, you can block on that issue being fixed.