[StepSecurity] Update the pre-commit configuration #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
step-security-bot
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
changed the title
larseggert
approved these changes
Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 110 110
Lines 35773 35773
=======================================
Hits 33918 33918
Misses 1855 1855 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to ea54273. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [195.65 ns 196.11 ns 196.61 ns]
change: [+2.1496% +2.5117% +2.8617%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low severe
8 (8.00%) high mild
7 (7.00%) high severecoalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [236.50 ns 237.03 ns 237.61 ns]
change: [+1.5257% +1.8942% +2.3053%] (p = 0.00 < 0.05)
Found 11 outliers among 100 measurements (11.00%)
11 (11.00%) high severecoalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [236.88 ns 237.69 ns 238.64 ns]
change: [+1.0166% +1.5597% +2.0684%] (p = 0.00 < 0.05)
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) high mild
7 (7.00%) high severecoalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [217.61 ns 217.78 ns 217.97 ns]
change: [+0.0386% +0.8423% +1.5483%] (p = 0.02 < 0.05)
Found 17 outliers among 100 measurements (17.00%)
4 (4.00%) high mild
13 (13.00%) high severeRxStreamOrderer::inbound_frame(): No change in performance detected. time: [117.88 ms 117.98 ms 118.09 ms]
change: [-0.1871% -0.0712% +0.0431%] (p = 0.24 > 0.05)
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/Run multiple transfers with varying seeds: Change within noise threshold. time: [120.45 ms 120.73 ms 121.01 ms]
thrpt: [33.054 MiB/s 33.131 MiB/s 33.208 MiB/s]
change:
time: [+0.4235% +0.7233% +1.0454%] (p = 0.00 < 0.05)
thrpt: [-1.0345% -0.7181% -0.4217%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [1.0914 s 1.1184 s 1.1490 s]
thrpt: [87.034 MiB/s 89.412 MiB/s 91.626 MiB/s]
change:
time: [-0.6268% +2.7697% +6.4014%] (p = 0.17 > 0.05)
thrpt: [-6.0163% -2.6951% +0.6307%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [42.410 ms 42.556 ms 42.722 ms]
thrpt: [23.407 elem/s 23.499 elem/s 23.579 elem/s]
change:
time: [-0.3190% +0.2168% +0.7467%] (p = 0.43 > 0.05)
thrpt: [-0.7412% -0.2163% +0.3201%]
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severeClient/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is created by StepSecurity at the request of @larseggert. Please merge the Pull Request to incorporate the requested changes. Please tag @larseggert on your message if you have any questions related to the PR.
Security Fixes
Maintain Code Quality with Pre-Commit
Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.
Feedback
For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot bot@stepsecurity.io