Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Update Dependabot configuration #1951

Merged

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @larseggert. Please merge the Pull Request to incorporate the requested changes. Please tag @larseggert on your message if you have any questions related to the PR.

Security Fixes

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@larseggert larseggert changed the title [StepSecurity] Apply security best practices [StepSecurity] Update Dependabot configuration Jul 2, 2024
Signed-off-by: Lars Eggert <lars@eggert.org>
Copy link

github-actions bot commented Jul 2, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@larseggert larseggert enabled auto-merge July 2, 2024 08:21
@larseggert larseggert added this pull request to the merge queue Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (c9ff46e) to head (27630de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
+ Coverage   94.81%   94.84%   +0.02%     
==========================================
  Files         110      110              
  Lines       35773    35773              
==========================================
+ Hits        33918    33928      +10     
+ Misses       1855     1845      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into mozilla:main with commit a8e2363 Jul 2, 2024
56 checks passed
Copy link

github-actions bot commented Jul 2, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Copy link

github-actions bot commented Jul 2, 2024

Benchmark results

Performance differences relative to ea54273.

coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed.
       time:   [200.46 ns 200.92 ns 201.41 ns]
       change: [+4.7889% +5.1733% +5.5632%] (p = 0.00 < 0.05)
Found 13 outliers among 100 measurements (13.00%)
  5 (5.00%) high mild
  8 (8.00%) high severe
coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed.
       time:   [244.80 ns 245.33 ns 245.91 ns]
       change: [+5.0065% +5.3475% +5.6895%] (p = 0.00 < 0.05)
Found 13 outliers among 100 measurements (13.00%)
  13 (13.00%) high severe
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed.
       time:   [245.49 ns 246.24 ns 247.15 ns]
       change: [+4.7124% +5.5513% +6.6254%] (p = 0.00 < 0.05)
Found 8 outliers among 100 measurements (8.00%)
  8 (8.00%) high severe
coalesce_acked_from_zero 1000+1 entries: 💔 Performance has regressed.
       time:   [225.01 ns 225.17 ns 225.34 ns]
       change: [+3.3551% +4.1828% +4.8813%] (p = 0.00 < 0.05)
Found 21 outliers among 100 measurements (21.00%)
  4 (4.00%) low mild
  6 (6.00%) high mild
  11 (11.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [118.34 ms 118.44 ms 118.54 ms]
       change: [+0.1966% +0.3130% +0.4298%] (p = 0.00 < 0.05)

transfer/Run multiple transfers with varying seeds
time: [122.51 ms 122.80 ms 123.08 ms]
thrpt: [32.500 MiB/s 32.575 MiB/s 32.650 MiB/s]
change:
time: [+2.1208% +2.4425% +2.7603%] (p = 0.00 < 0.05)
thrpt: [-2.6861% -2.3842% -2.0768%]
Change within noise threshold.

transfer/Run multiple transfers with the same seed: Change within noise threshold.
       time:   [122.88 ms 123.06 ms 123.24 ms]
       thrpt:  [32.456 MiB/s 32.505 MiB/s 32.553 MiB/s]
change:
       time:   [+2.2023% +2.4162% +2.6503%] (p = 0.00 < 0.05)
       thrpt:  [-2.5819% -2.3592% -2.1548%]
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [1.0881 s 1.1180 s 1.1474 s]
       thrpt:  [87.154 MiB/s 89.445 MiB/s 91.901 MiB/s]
change:
       time:   [-0.9042% +2.7319% +6.3722%] (p = 0.17 > 0.05)
       thrpt:  [-5.9905% -2.6592% +0.9125%]

1-conn/10_000-parallel-1b-resp (aka. RPS)/client
time: [389.11 ms 392.33 ms 395.59 ms]
thrpt: [25.279 Kelem/s 25.489 Kelem/s 25.699 Kelem/s]
change:
time: [-1.1941% -0.0729% +1.0878%] (p = 0.89 > 0.05)
thrpt: [-1.0761% +0.0729% +1.2085%]
No change in performance detected.

1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold.
       time:   [41.775 ms 41.881 ms 42.002 ms]
       thrpt:  [23.808  elem/s 23.877  elem/s 23.938  elem/s]
change:
       time:   [-1.8517% -1.3727% -0.8988%] (p = 0.00 < 0.05)
       thrpt:  [+0.9069% +1.3918% +1.8866%]
Found 21 outliers among 100 measurements (21.00%)
  14 (14.00%) low severe
  7 (7.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 158.3 ± 46.5 102.1 255.3 1.00
neqo msquic reno on 268.3 ± 13.0 255.5 294.4 1.00
neqo msquic reno 270.8 ± 12.6 253.4 297.5 1.00
neqo msquic cubic on 272.7 ± 11.0 255.0 285.3 1.00
neqo msquic cubic 308.6 ± 70.5 266.9 470.4 1.00
msquic neqo reno on 951.0 ± 14.7 933.9 976.0 1.00
msquic neqo reno 918.1 ± 12.7 897.5 936.6 1.00
msquic neqo cubic on 886.7 ± 10.1 878.9 911.4 1.00
msquic neqo cubic 881.2 ± 13.1 862.2 904.4 1.00
neqo neqo reno on 912.8 ± 10.7 901.5 930.0 1.00
neqo neqo reno 904.3 ± 70.8 706.5 954.1 1.00
neqo neqo cubic on 884.5 ± 6.1 877.5 897.3 1.00
neqo neqo cubic 870.0 ± 12.1 852.8 883.2 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants