test(server): drop short header packet for unknown connection #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a basic test, passing a short header packet to a fresh server, expecting the server to drop the packet for the unknown connection.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
=======================================
Coverage 94.81% 94.82%
=======================================
Files 110 110
Lines 35773 35773
=======================================
+ Hits 33918 33920 +2
+ Misses 1855 1853 -2 ☔ View full report in Codecov by Sentry. |
larseggert
approved these changes
Jul 2, 2024
Benchmark resultsPerformance differences relative to ea54273. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [196.19 ns 196.64 ns 197.11 ns]
change: [+2.3392% +2.6876% +3.0404%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)
9 (9.00%) high mild
7 (7.00%) high severecoalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [237.38 ns 238.10 ns 238.92 ns]
change: [+1.8970% +2.3222% +2.7914%] (p = 0.00 < 0.05)
Found 15 outliers among 100 measurements (15.00%)
1 (1.00%) low mild
2 (2.00%) high mild
12 (12.00%) high severecoalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [237.25 ns 237.96 ns 238.83 ns]
change: [+1.3296% +1.9798% +2.6207%] (p = 0.00 < 0.05)
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severecoalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [217.94 ns 218.06 ns 218.20 ns]
change: [+0.0717% +0.8652% +1.5373%] (p = 0.01 < 0.05)
Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
10 (10.00%) high severeRxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [119.34 ms 119.42 ms 119.49 ms]
change: [+1.0346% +1.1415% +1.2446%] (p = 0.00 < 0.05)
Found 6 outliers among 100 measurements (6.00%)
5 (5.00%) high mild
1 (1.00%) high severetransfer/Run multiple transfers with varying seeds: Change within noise threshold. time: [121.52 ms 121.82 ms 122.12 ms]
thrpt: [32.754 MiB/s 32.834 MiB/s 32.916 MiB/s]
change:
time: [+1.2983% +1.6315% +1.9530%] (p = 0.00 < 0.05)
thrpt: [-1.9156% -1.6053% -1.2816%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [1.0540 s 1.0778 s 1.1055 s]
thrpt: [90.460 MiB/s 92.785 MiB/s 94.873 MiB/s]
change:
time: [-4.2557% -0.9666% +2.5049%] (p = 0.60 > 0.05)
thrpt: [-2.4437% +0.9760% +4.4448%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [42.255 ms 42.394 ms 42.553 ms]
thrpt: [23.500 elem/s 23.588 elem/s 23.666 elem/s]
change:
time: [-0.6844% -0.1633% +0.3718%] (p = 0.55 > 0.05)
thrpt: [-0.3704% +0.1636% +0.6891%]
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severeClient/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a basic test, passing a short header packet to a fresh server, expecting the server to drop the packet for the unknown connection.
More specifically, it tests this code path:
neqo/neqo-transport/src/server.rs
Lines 564 to 568 in c9ff46e