chore: address nightly clippy lints #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See corresponding lints: - https://rust-lang.github.io/rust-clippy/master/index.html#/mutable_key_type - https://rust-lang.github.io/rust-clippy/master/index.html#/manual_inspect See recent CI failure: https://github.com/mozilla/neqo/actions/runs/9759065486/job/26934981259 ``` error: --> neqo-transport/src/path.rs:214:62 | 214 | let old_path = self.primary.replace(Rc::clone(path)).map(|old| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `-D clippy::manual-inspect` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]` help: try | 214 ~ let old_path = self.primary.replace(Rc::clone(path)).inspect(|old| { 215 ~ old.borrow_mut().set_primary(false); | error: mutable key type --> neqo-transport/src/server.rs:603:45 | 603 | pub fn active_connections(&mut self) -> HashSet<ActiveConnectionRef> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type = note: `-D clippy::mutable-key-type` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]` error: could not compile `neqo-transport` (lib) due to 2 previous errors error: process didn't exit successfully: `/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo clippy --all-targets --manifest-path fuzz/Cargo.toml -- -D warnings` (exit status: 101) ```
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 110 110
Lines 35722 35722
=======================================
Hits 33864 33864
Misses 1858 1858 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 2e1f92e. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [187.61 ns 188.05 ns 188.50 ns]
change: [-0.6910% -0.3547% +0.0337%] (p = 0.05 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [230.12 ns 230.66 ns 231.24 ns]
change: [-1.3661% -0.4079% +0.3388%] (p = 0.40 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [230.24 ns 231.11 ns 232.24 ns]
change: [-0.2495% +0.3879% +1.2418%] (p = 0.40 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [213.02 ns 213.21 ns 213.42 ns]
change: [-0.7316% -0.0473% +0.5814%] (p = 0.89 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [118.80 ms 118.91 ms 119.02 ms]
change: [+0.2219% +0.3296% +0.4335%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [121.54 ms 121.82 ms 122.09 ms]
thrpt: [32.763 MiB/s 32.837 MiB/s 32.912 MiB/s]
change:
time: [-0.5356% -0.2082% +0.0995%] (p = 0.21 > 0.05)
thrpt: [-0.0994% +0.2086% +0.5385%]
transfer/Run multiple transfers with the same seed: Change within noise threshold. time: [121.55 ms 121.73 ms 121.90 ms]
thrpt: [32.812 MiB/s 32.861 MiB/s 32.909 MiB/s]
change:
time: [-0.9134% -0.7150% -0.5074%] (p = 0.00 < 0.05)
thrpt: [+0.5100% +0.7201% +0.9218%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [1.0860 s 1.1089 s 1.1369 s]
thrpt: [87.956 MiB/s 90.176 MiB/s 92.078 MiB/s]
change:
time: [-5.2485% -2.2538% +0.8077%] (p = 0.20 > 0.05)
thrpt: [-0.8012% +2.3057% +5.5392%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [439.69 ms 442.53 ms 445.39 ms]
thrpt: [22.452 Kelem/s 22.597 Kelem/s 22.743 Kelem/s]
change:
time: [-0.6205% +0.3037% +1.1410%] (p = 0.51 > 0.05)
thrpt: [-1.1281% -0.3028% +0.6244%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [45.264 ms 45.485 ms 45.713 ms]
thrpt: [21.876 elem/s 21.985 elem/s 22.092 elem/s]
change:
time: [-0.6076% +0.1407% +0.8753%] (p = 0.72 > 0.05)
thrpt: [-0.8677% -0.1405% +0.6113%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See corresponding lints:
See recent CI failure:
https://github.com/mozilla/neqo/actions/runs/9759065486/job/26934981259