chore: Turn on more clippy lints, and fix the warnings #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Jul 3, 2024
Benchmark resultsPerformance differences relative to cf72ed4. coalesce_acked_from_zero 1+1 entries: 💚 Performance has improved. time: [190.18 ns 190.66 ns 191.17 ns]
change: [-2.0077% -1.6096% -1.2179%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [232.75 ns 233.24 ns 233.76 ns]
change: [-0.4987% -0.1309% +0.2264%] (p = 0.50 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [232.41 ns 233.14 ns 234.01 ns]
change: [-0.5898% -0.2457% +0.0795%] (p = 0.16 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [211.88 ns 212.11 ns 212.37 ns]
change: [-0.8261% -0.2338% +0.4957%] (p = 0.51 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [118.70 ms 118.77 ms 118.85 ms]
change: [-0.1007% -0.0272% +0.0491%] (p = 0.48 > 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [121.99 ms 122.28 ms 122.56 ms]
thrpt: [32.636 MiB/s 32.711 MiB/s 32.789 MiB/s]
change:
time: [-0.1081% +0.2279% +0.5646%] (p = 0.17 > 0.05)
thrpt: [-0.5614% -0.2274% +0.1083%]
transfer/Run multiple transfers with the same seed: Change within noise threshold. time: [122.62 ms 122.80 ms 122.97 ms]
thrpt: [32.527 MiB/s 32.574 MiB/s 32.621 MiB/s]
change:
time: [+0.2089% +0.4066% +0.6087%] (p = 0.00 < 0.05)
thrpt: [-0.6051% -0.4049% -0.2084%]
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [1.0618 s 1.0776 s 1.0960 s]
thrpt: [91.240 MiB/s 92.796 MiB/s 94.180 MiB/s]
change:
time: [-8.0756% -5.8847% -3.6486%] (p = 0.00 < 0.05)
thrpt: [+3.7868% +6.2527% +8.7850%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [440.11 ms 442.92 ms 445.82 ms]
thrpt: [22.431 Kelem/s 22.577 Kelem/s 22.722 Kelem/s]
change:
time: [-0.0622% +0.8189% +1.6714%] (p = 0.06 > 0.05)
thrpt: [-1.6439% -0.8123% +0.0623%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [45.022 ms 45.249 ms 45.486 ms]
thrpt: [21.985 elem/s 22.100 elem/s 22.211 elem/s]
change:
time: [-0.9860% -0.2995% +0.3656%] (p = 0.40 > 0.05)
thrpt: [-0.3642% +0.3004% +0.9958%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
larseggert
force-pushed
the
chore-more-clippy
branch
from
a264142
to
1227789
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
+ Coverage 94.78% 94.83% +0.05%
==========================================
Files 111 111
Lines 35896 35880 -16
==========================================
+ Hits 34024 34028 +4
+ Misses 1872 1852 -20 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.