Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dependency-review needs refs for merge_queue #1961

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert merged commit 34a5126 into mozilla:main Jul 4, 2024
20 checks passed
@larseggert larseggert deleted the ci-depreview-refs branch July 4, 2024 05:50
Copy link

github-actions bot commented Jul 4, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

Copy link

github-actions bot commented Jul 4, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Copy link

github-actions bot commented Jul 4, 2024

Benchmark results

Performance differences relative to cf72ed4.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [191.88 ns 192.34 ns 192.86 ns]
       change: [-0.7661% -0.3314% +0.0781%] (p = 0.14 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [234.31 ns 234.91 ns 235.54 ns]
       change: [+0.1885% +0.6291% +1.0283%] (p = 0.00 < 0.05)

Found 20 outliers among 100 measurements (20.00%)
2 (2.00%) low mild
8 (8.00%) high mild
10 (10.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [233.66 ns 234.50 ns 235.49 ns]
       change: [+0.3314% +0.7398% +1.1624%] (p = 0.00 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [213.66 ns 213.85 ns 214.07 ns]
       change: [-0.0301% +0.5637% +1.1901%] (p = 0.07 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [118.51 ms 118.60 ms 118.69 ms]
       change: [-0.2530% -0.1714% -0.0802%] (p = 0.00 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mild

transfer/Run multiple transfers with varying seeds: Change within noise threshold.
       time:   [123.03 ms 123.28 ms 123.54 ms]
       thrpt:  [32.378 MiB/s 32.445 MiB/s 32.513 MiB/s]
change:
       time:   [+0.7417% +1.0501% +1.3507%] (p = 0.00 < 0.05)
       thrpt:  [-1.3327% -1.0392% -0.7362%]
transfer/Run multiple transfers with the same seed: Change within noise threshold.
       time:   [123.27 ms 123.45 ms 123.63 ms]
       thrpt:  [32.355 MiB/s 32.402 MiB/s 32.448 MiB/s]
change:
       time:   [+0.7325% +0.9391% +1.1470%] (p = 0.00 < 0.05)
       thrpt:  [-1.1340% -0.9303% -0.7272%]

Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [1.0911 s 1.1177 s 1.1453 s]
       thrpt:  [87.312 MiB/s 89.473 MiB/s 91.649 MiB/s]
change:
       time:   [-5.2489% -2.3895% +0.3148%] (p = 0.14 > 0.05)
       thrpt:  [-0.3138% +2.4480% +5.5397%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [437.44 ms 440.02 ms 442.60 ms]
       thrpt:  [22.594 Kelem/s 22.726 Kelem/s 22.860 Kelem/s]
change:
       time:   [-0.6080% +0.1570% +0.9754%] (p = 0.70 > 0.05)
       thrpt:  [-0.9660% -0.1568% +0.6117%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [45.173 ms 45.429 ms 45.691 ms]
       thrpt:  [21.886  elem/s 22.012  elem/s 22.137  elem/s]
change:
       time:   [-0.6231% +0.0970% +0.8291%] (p = 0.80 > 0.05)
       thrpt:  [-0.8223% -0.0969% +0.6270%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 192.0 ± 95.7 100.0 380.4 1.00
neqo msquic reno on 286.5 ± 60.9 257.3 458.8 1.00
neqo msquic reno 300.7 ± 66.0 250.4 481.4 1.00
neqo msquic cubic on 330.0 ± 87.4 258.1 473.2 1.00
neqo msquic cubic 317.5 ± 77.7 255.0 481.0 1.00
msquic neqo reno on 974.6 ± 17.1 951.8 1000.7 1.00
msquic neqo reno 968.6 ± 45.6 936.5 1083.1 1.00
msquic neqo cubic on 935.2 ± 19.3 904.7 962.4 1.00
msquic neqo cubic 922.9 ± 37.6 891.5 1010.4 1.00
neqo neqo reno on 975.7 ± 14.6 952.2 1005.6 1.00
neqo neqo reno 999.7 ± 41.1 971.8 1100.5 1.00
neqo neqo cubic on 1005.6 ± 73.0 947.4 1188.8 1.00
neqo neqo cubic 975.3 ± 32.5 936.6 1047.9 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant