Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Report QNS results by client and server separately #1994

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jul 19, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (3a8f724) to head (7170307).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1994   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         112      112           
  Lines       36366    36366           
=======================================
  Hits        34547    34547           
  Misses       1819     1819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 19, 2024

Benchmark results

Performance differences relative to 3a8f724.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [190.51 ns 192.05 ns 194.78 ns]
       change: [-0.3253% +0.3265% +1.0931%] (p = 0.41 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [233.19 ns 233.88 ns 234.56 ns]
       change: [-0.2964% +0.1506% +0.5787%] (p = 0.51 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
1 (1.00%) low mild
12 (12.00%) high mild
9 (9.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [232.54 ns 233.29 ns 234.19 ns]
       change: [+0.0149% +0.3395% +0.6918%] (p = 0.04 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [216.08 ns 216.38 ns 216.63 ns]
       change: [-0.6109% -0.0472% +0.5331%] (p = 0.88 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [119.59 ms 119.76 ms 119.98 ms]
       change: [-0.1464% +0.1103% +0.3588%] (p = 0.42 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

transfer/Run multiple transfers with varying seeds: No change in performance detected.
       time:   [51.339 ms 54.160 ms 56.988 ms]
       thrpt:  [70.191 MiB/s 73.855 MiB/s 77.914 MiB/s]
change:
       time:   [-12.171% -5.4391% +1.7728%] (p = 0.15 > 0.05)
       thrpt:  [-1.7419% +5.7520% +13.857%]
transfer/Run multiple transfers with the same seed: Change within noise threshold.
       time:   [67.666 ms 74.187 ms 80.696 ms]
       thrpt:  [49.569 MiB/s 53.917 MiB/s 59.114 MiB/s]
change:
       time:   [+0.4693% +14.486% +30.224%] (p = 0.04 < 0.05)
       thrpt:  [-23.209% -12.653% -0.4671%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [291.80 ms 296.32 ms 301.51 ms]
       thrpt:  [331.66 MiB/s 337.47 MiB/s 342.71 MiB/s]
change:
       time:   [-2.2773% +2.2995% +8.4709%] (p = 0.46 > 0.05)
       thrpt:  [-7.8094% -2.2478% +2.3304%]

Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [408.95 ms 412.10 ms 415.22 ms]
       thrpt:  [24.084 Kelem/s 24.266 Kelem/s 24.453 Kelem/s]
change:
       time:   [-1.5583% -0.4437% +0.7524%] (p = 0.46 > 0.05)
       thrpt:  [-0.7468% +0.4457% +1.5830%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [68.063 ms 68.417 ms 68.819 ms]
       thrpt:  [14.531  elem/s 14.616  elem/s 14.692  elem/s]
change:
       time:   [-0.7875% +0.0093% +0.7351%] (p = 0.98 > 0.05)
       thrpt:  [-0.7297% -0.0093% +0.7938%]

Found 12 outliers among 100 measurements (12.00%)
4 (4.00%) low mild
8 (8.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 145.1 ± 57.7 100.3 325.3 1.00
neqo msquic reno on 327.6 ± 88.8 261.5 504.4 1.00
neqo msquic reno 264.7 ± 9.4 252.3 282.7 1.00
neqo msquic cubic on 288.0 ± 63.1 254.2 466.5 1.00
neqo msquic cubic 285.3 ± 60.7 252.9 455.6 1.00
msquic neqo reno on 183.4 ± 60.5 150.0 349.0 1.00
msquic neqo reno 200.2 ± 95.3 139.1 445.7 1.00
msquic neqo cubic on 840.4 ± 2101.3 123.1 7504.7 1.00
msquic neqo cubic 256.2 ± 85.6 151.2 400.3 1.00
neqo neqo reno on 180.8 ± 19.7 156.0 224.6 1.00
neqo neqo reno 204.9 ± 71.5 149.8 387.6 1.00
neqo neqo cubic on 237.9 ± 87.0 157.9 400.4 1.00
neqo neqo cubic 227.6 ± 83.7 169.8 405.3 1.00

⬇️ Download logs

@larseggert larseggert merged commit 2e419cc into mozilla:main Jul 19, 2024
57 checks passed
@larseggert larseggert deleted the ci-qns-split-results branch July 19, 2024 12:54
Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant