chore: Remove superfluous clippy allows #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that nightly has experimental support for https://rust-lang.github.io/rfcs/2383-lint-reasons.html, use that to identify superfluous clippy allows and remove them.
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
- Coverage 94.99% 94.99% -0.01%
==========================================
Files 112 112
Lines 36371 36363 -8
==========================================
- Hits 34552 34543 -9
- Misses 1819 1820 +1 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 88d3ed1. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [192.91 ns 193.40 ns 193.89 ns]
change: [+0.1551% +0.4907% +0.8307%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [236.67 ns 237.27 ns 237.95 ns]
change: [+0.4880% +1.0345% +1.6191%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [237.62 ns 238.62 ns 239.76 ns]
change: [+0.4434% +1.1803% +1.8471%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [216.40 ns 216.52 ns 216.65 ns]
change: [-1.2402% -0.6469% -0.0373%] (p = 0.03 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [119.44 ms 119.57 ms 119.70 ms]
change: [-1.1371% -0.9000% -0.7124%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [54.610 ms 58.086 ms 61.527 ms]
thrpt: [65.012 MiB/s 68.863 MiB/s 73.247 MiB/s]
change:
time: [-4.4820% +3.9166% +13.060%] (p = 0.37 > 0.05)
thrpt: [-11.551% -3.7690% +4.6923%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [66.332 ms 73.058 ms 79.685 ms]
thrpt: [50.198 MiB/s 54.751 MiB/s 60.303 MiB/s]
change:
time: [-13.217% -1.6675% +11.737%] (p = 0.79 > 0.05)
thrpt: [-10.504% +1.6958% +15.229%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [290.09 ms 297.28 ms 305.40 ms]
thrpt: [327.44 MiB/s 336.38 MiB/s 344.72 MiB/s]
change:
time: [-2.3666% +1.6244% +5.5118%] (p = 0.45 > 0.05)
thrpt: [-5.2239% -1.5984% +2.4239%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: 💔 Performance has regressed. time: [415.20 ms 418.71 ms 422.19 ms]
thrpt: [23.686 Kelem/s 23.883 Kelem/s 24.085 Kelem/s]
change:
time: [+1.5989% +2.7888% +3.9221%] (p = 0.00 < 0.05)
thrpt: [-3.7741% -2.7131% -1.5737%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [67.992 ms 68.224 ms 68.499 ms]
thrpt: [14.599 elem/s 14.658 elem/s 14.708 elem/s]
change:
time: [-0.8692% -0.2335% +0.3717%] (p = 0.47 > 0.05)
thrpt: [-0.3703% +0.2341% +0.8769%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Jul 22, 2024
|
Most clippied codebase I have ever worked on 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that nightly has experimental support for
https://rust-lang.github.io/rfcs/2383-lint-reasons.html, use that to identify superfluous clippy allows and remove them.