Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip sudo runner steps on self-hosted runner #2022

Merged
merged 3 commits into from
Jul 30, 2024
Merged

ci: Skip sudo runner steps on self-hosted runner #2022

merged 3 commits into from
Jul 30, 2024

Conversation

larseggert
Copy link
Collaborator

Because the script runs without sudo permissions. Deps must be installed by admin.

Because the script runs without `sudo` permissions. Deps must be
installed by admin.
Copy link

github-actions bot commented Jul 30, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (7e96081) to head (95bda7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         112      112           
  Lines       36364    36364           
=======================================
+ Hits        34547    34548    +1     
+ Misses       1817     1816    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 30, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert larseggert merged commit b22512c into main Jul 30, 2024
58 of 59 checks passed
@larseggert larseggert deleted the fix-sudo branch July 30, 2024 11:30
Copy link

Benchmark results

Performance differences relative to cecad73.

coalesce_acked_from_zero 1+1 entries: 💚 Performance has improved.
       time:   [191.43 ns 191.92 ns 192.43 ns]
       change: [-3.0573% -2.7034% -2.3414%] (p = 0.00 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: 💚 Performance has improved.
       time:   [235.55 ns 236.08 ns 236.67 ns]
       change: [-2.8436% -2.4950% -2.1262%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
1 (1.00%) low mild
3 (3.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: 💚 Performance has improved.
       time:   [235.50 ns 236.27 ns 237.20 ns]
       change: [-3.3071% -2.6413% -2.1094%] (p = 0.00 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: 💚 Performance has improved.
       time:   [215.48 ns 215.87 ns 216.33 ns]
       change: [-3.4833% -2.8621% -2.2379%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [118.95 ms 119.01 ms 119.08 ms]
       change: [+0.1064% +0.3260% +0.4697%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [40.272 ms 42.274 ms 44.309 ms]
       change: [-5.0757% +1.6189% +8.1956%] (p = 0.62 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [52.222 ms 55.214 ms 58.247 ms]
       change: [-6.9523% +0.2544% +8.4308%] (p = 0.95 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [48.713 ms 50.428 ms 52.086 ms]
       change: [-1.6225% +3.3899% +8.5411%] (p = 0.18 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [67.939 ms 73.956 ms 79.939 ms]
       change: [-9.5510% +1.3533% +15.032%] (p = 0.83 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [245.67 ms 257.86 ms 269.73 ms]
       thrpt:  [370.74 MiB/s 387.81 MiB/s 407.05 MiB/s]
change:
       time:   [-5.6425% +0.4618% +7.2254%] (p = 0.90 > 0.05)
       thrpt:  [-6.7385% -0.4596% +5.9799%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [411.94 ms 415.69 ms 419.50 ms]
       thrpt:  [23.838 Kelem/s 24.057 Kelem/s 24.275 Kelem/s]
change:
       time:   [-1.8878% -0.6148% +0.6003%] (p = 0.34 > 0.05)
       thrpt:  [-0.5967% +0.6186% +1.9241%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [66.897 ms 67.239 ms 67.628 ms]
       thrpt:  [14.787  elem/s 14.872  elem/s 14.948  elem/s]
change:
       time:   [-0.3726% +0.3422% +1.1389%] (p = 0.37 > 0.05)
       thrpt:  [-1.1260% -0.3411% +0.3739%]

Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 117.4 ± 20.2 98.3 197.4 1.00
neqo msquic reno on 299.7 ± 79.3 258.4 516.6 1.00
neqo msquic reno 296.3 ± 74.0 260.0 505.3 1.00
neqo msquic cubic on 262.7 ± 9.6 249.0 281.3 1.00
neqo msquic cubic 261.1 ± 9.1 249.6 279.7 1.00
msquic neqo reno on 225.8 ± 133.5 151.5 531.8 1.00
msquic neqo reno 154.8 ± 49.3 111.5 323.1 1.00
msquic neqo cubic on 172.5 ± 54.9 141.8 349.1 1.00
msquic neqo cubic 188.2 ± 62.3 111.7 398.7 1.00
neqo neqo reno on 214.5 ± 61.3 171.9 379.0 1.00
neqo neqo reno 197.9 ± 72.7 149.1 401.6 1.00
neqo neqo cubic on 203.8 ± 71.1 157.4 397.1 1.00
neqo neqo cubic 176.6 ± 9.6 163.5 204.4 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant