Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Simplify QNS output #2023

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ci: Simplify QNS output #2023

merged 1 commit into from
Jul 30, 2024

Conversation

larseggert
Copy link
Collaborator

Now that we're sorting by role, no need to underline. Also fix issue when there are no results.

Now that we're sorting by role, no need to underline. Also fix issue
when there are no results.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (b22512c) to head (f5018fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2023   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         112      112           
  Lines       36364    36364           
=======================================
+ Hits        34546    34549    +3     
+ Misses       1818     1815    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert merged commit 4dc6ca4 into main Jul 30, 2024
56 of 59 checks passed
@larseggert larseggert deleted the ci-qns-simplify branch July 30, 2024 13:28
Copy link

Benchmark results

Performance differences relative to b22512c.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [191.58 ns 192.07 ns 192.61 ns]
       change: [-0.0140% +0.3186% +0.7063%] (p = 0.08 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [235.45 ns 236.07 ns 236.76 ns]
       change: [-0.8461% -0.3209% +0.1289%] (p = 0.22 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low mild
3 (3.00%) high mild
9 (9.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [236.08 ns 236.94 ns 237.95 ns]
       change: [-1.1144% -0.5402% -0.0340%] (p = 0.05 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) low mild
1 (1.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [215.46 ns 215.61 ns 215.78 ns]
       change: [-0.4280% +0.1787% +0.7443%] (p = 0.59 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
7 (7.00%) high mild
8 (8.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [119.28 ms 119.42 ms 119.65 ms]
       change: [+0.2607% +0.5019% +0.7445%] (p = 0.00 < 0.05)

Found 19 outliers among 100 measurements (19.00%)
1 (1.00%) low severe
5 (5.00%) low mild
7 (7.00%) high mild
6 (6.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [40.691 ms 42.932 ms 45.187 ms]
       change: [-6.2858% +0.8688% +8.8237%] (p = 0.82 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [53.615 ms 56.686 ms 59.774 ms]
       change: [-6.2517% +1.2095% +9.5978%] (p = 0.76 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [48.321 ms 49.935 ms 51.473 ms]
       change: [-0.8452% +3.7281% +8.3116%] (p = 0.12 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) low mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [66.417 ms 72.967 ms 79.497 ms]
       change: [-11.345% +0.9494% +14.168%] (p = 0.88 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [252.73 ms 263.39 ms 273.55 ms]
       thrpt:  [365.57 MiB/s 379.66 MiB/s 395.68 MiB/s]
change:
       time:   [-11.097% -3.8294% +3.0462%] (p = 0.32 > 0.05)
       thrpt:  [-2.9562% +3.9818% +12.482%]

Found 24 outliers among 100 measurements (24.00%)
2 (2.00%) low severe
22 (22.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold.
       time:   [422.81 ms 426.85 ms 430.86 ms]
       thrpt:  [23.210 Kelem/s 23.428 Kelem/s 23.652 Kelem/s]
change:
       time:   [+0.8602% +2.1874% +3.5067%] (p = 0.00 < 0.05)
       thrpt:  [-3.3879% -2.1406% -0.8528%]

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [67.015 ms 67.385 ms 67.797 ms]
       thrpt:  [14.750  elem/s 14.840  elem/s 14.922  elem/s]
change:
       time:   [-0.4459% +0.3637% +1.0759%] (p = 0.38 > 0.05)
       thrpt:  [-1.0644% -0.3623% +0.4479%]

Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) low mild
8 (8.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 154.4 ± 73.3 104.0 327.0 1.00
neqo msquic reno on 318.0 ± 85.5 257.2 480.1 1.00
neqo msquic reno 265.1 ± 9.8 253.6 283.9 1.00
neqo msquic cubic on 295.5 ± 74.7 262.6 506.5 1.00
neqo msquic cubic 263.5 ± 9.0 249.4 278.7 1.00
msquic neqo reno on 163.1 ± 11.6 151.5 183.2 1.00
msquic neqo reno 144.9 ± 17.7 111.6 173.6 1.00
msquic neqo cubic on 196.5 ± 78.7 140.9 352.2 1.00
msquic neqo cubic 190.2 ± 61.2 135.8 401.7 1.00
neqo neqo reno on 219.5 ± 100.8 148.8 498.0 1.00
neqo neqo reno 210.5 ± 70.3 157.4 393.3 1.00
neqo neqo cubic on 185.5 ± 22.7 152.6 252.8 1.00
neqo neqo cubic 207.7 ± 62.1 167.6 392.9 1.00

⬇️ Download logs

Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant