chore: Remove test_ from test names
#2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make @martinthomson happy :-)
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 112 112
Lines 36364 36364
=======================================
+ Hits 34546 34548 +2
+ Misses 1818 1816 -2 ☔ View full report in Codecov by Sentry. |
KershawChang
approved these changes
Jul 31, 2024
Benchmark resultsPerformance differences relative to 4dc6ca4. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [195.77 ns 196.25 ns 196.75 ns]
change: [+1.2089% +1.5393% +1.8955%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [235.54 ns 236.15 ns 236.81 ns]
change: [-0.4531% +0.0042% +0.4117%] (p = 0.99 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [236.03 ns 237.20 ns 238.57 ns]
change: [-0.9599% -0.2566% +0.5778%] (p = 0.53 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [217.38 ns 217.61 ns 217.94 ns]
change: [-0.1249% +0.5823% +1.2388%] (p = 0.11 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [119.23 ms 119.37 ms 119.61 ms]
change: [+0.0249% +0.1592% +0.3647%] (p = 0.05 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [40.029 ms 41.878 ms 43.773 ms]
change: [-8.9600% -1.7980% +5.5612%] (p = 0.63 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [54.209 ms 57.918 ms 61.631 ms]
change: [-8.0939% +0.2371% +9.7016%] (p = 0.95 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [47.197 ms 48.997 ms 50.726 ms]
change: [-8.6910% -4.1889% +0.4307%] (p = 0.08 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [63.718 ms 71.112 ms 78.556 ms]
change: [-20.245% -7.5569% +5.3023%] (p = 0.26 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [260.80 ms 271.37 ms 281.26 ms]
thrpt: [355.54 MiB/s 368.50 MiB/s 383.43 MiB/s]
change:
time: [-4.4387% +0.7384% +6.2345%] (p = 0.78 > 0.05)
thrpt: [-5.8686% -0.7330% +4.6449%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [414.94 ms 418.78 ms 422.58 ms]
thrpt: [23.664 Kelem/s 23.879 Kelem/s 24.100 Kelem/s]
change:
time: [-1.1570% +0.1067% +1.3829%] (p = 0.87 > 0.05)
thrpt: [-1.3640% -0.1066% +1.1705%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [67.047 ms 67.338 ms 67.669 ms]
thrpt: [14.778 elem/s 14.850 elem/s 14.915 elem/s]
change:
time: [-0.6538% +0.0463% +0.7924%] (p = 0.90 > 0.05)
thrpt: [-0.7862% -0.0463% +0.6581%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make @martinthomson happy :-)