fix(common/qlog): use BufWriter #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
mxinden
commented
Aug 2, 2024
larseggert
approved these changes
Aug 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
- Coverage 95.36% 95.35% -0.01%
==========================================
Files 112 112
Lines 36463 36463
==========================================
- Hits 34772 34771 -1
- Misses 1691 1692 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 7cbd776. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [194.08 ns 194.48 ns 194.92 ns]
change: [+0.3649% +0.9018% +1.4313%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [236.37 ns 237.16 ns 237.98 ns]
change: [+0.9664% +1.3328% +1.7061%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [235.67 ns 236.44 ns 237.37 ns]
change: [+0.4829% +1.1743% +2.3196%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [216.68 ns 216.81 ns 216.97 ns]
change: [-0.1811% +0.5069% +1.1710%] (p = 0.15 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [120.65 ms 120.82 ms 121.05 ms]
change: [+0.0750% +0.2521% +0.4526%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [40.941 ms 42.973 ms 44.982 ms]
change: [-4.9448% +1.9217% +9.0063%] (p = 0.58 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [54.247 ms 57.569 ms 60.862 ms]
change: [-5.5019% +1.6085% +9.4351%] (p = 0.67 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [49.163 ms 50.559 ms 51.933 ms]
change: [-5.0449% -1.1030% +3.0897%] (p = 0.60 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [71.702 ms 78.377 ms 85.000 ms]
change: [-6.5813% +4.5571% +17.685%] (p = 0.45 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [171.08 ms 175.65 ms 183.06 ms]
thrpt: [546.28 MiB/s 569.31 MiB/s 584.51 MiB/s]
change:
time: [-1.4587% +1.4937% +6.3846%] (p = 0.53 > 0.05)
thrpt: [-6.0015% -1.4718% +1.4802%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [407.92 ms 411.72 ms 415.45 ms]
thrpt: [24.070 Kelem/s 24.288 Kelem/s 24.515 Kelem/s]
change:
time: [-2.3135% -1.0173% +0.3624%] (p = 0.13 > 0.05)
thrpt: [-0.3611% +1.0278% +2.3683%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [46.062 ms 46.761 ms 47.461 ms]
thrpt: [21.070 elem/s 21.385 elem/s 21.710 elem/s]
change:
time: [-2.0074% +0.0133% +2.1565%] (p = 0.99 > 0.05)
thrpt: [-2.1110% -0.0133% +2.0485%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
Resolving merge conflicts now. |
Instead of writing to a file directly, buffer writes through a `BufWriter`.
larseggert
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on a
neqo-server->neqo-clienttransfer with qlog enabled,neqo-clientwould spend the majority of time writing to the qlog file.Using a
BufWriterqlogwriting takes less than 3% of CPU time.Depends on #2031.