fix: Check whether CIDs are empty #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
martinthomson
previously requested changes
Aug 4, 2024
Co-authored-by: Martin Thomson <mt@lowentropy.net> Signed-off-by: Lars Eggert <lars@eggert.org>
KershawChang
approved these changes
Aug 5, 2024
mxinden
approved these changes
Aug 5, 2024
Co-authored-by: Max Inden <mail@max-inden.de> Signed-off-by: Lars Eggert <lars@eggert.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 112 112
Lines 36462 36474 +12
=======================================
+ Hits 34654 34666 +12
Misses 1808 1808 ☔ View full report in Codecov by Sentry. |
mxinden
approved these changes
Aug 6, 2024
Benchmark resultsPerformance differences relative to 80fd8e5. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [196.33 ns 196.83 ns 197.36 ns]
change: [+1.3666% +1.7409% +2.1687%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [237.07 ns 237.59 ns 238.17 ns]
change: [+0.3975% +0.8752% +1.2612%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [237.28 ns 237.96 ns 238.80 ns]
change: [+0.3610% +1.1569% +1.9686%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [214.14 ns 214.38 ns 214.66 ns]
change: [-0.8185% -0.1550% +0.5247%] (p = 0.67 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [121.52 ms 121.57 ms 121.63 ms]
change: [+0.2003% +0.4074% +0.5429%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [40.962 ms 42.694 ms 44.476 ms]
change: [-5.4237% -0.0481% +6.0398%] (p = 0.98 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [54.980 ms 58.090 ms 61.257 ms]
change: [-7.7520% +0.4049% +8.6703%] (p = 0.92 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [48.878 ms 50.344 ms 51.766 ms]
change: [-5.2892% -1.1434% +3.0349%] (p = 0.58 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [68.931 ms 75.817 ms 82.637 ms]
change: [-15.393% -4.3576% +7.5326%] (p = 0.47 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [169.08 ms 170.83 ms 172.78 ms]
thrpt: [578.78 MiB/s 585.37 MiB/s 591.42 MiB/s]
change:
time: [-0.9823% +0.3978% +1.8775%] (p = 0.59 > 0.05)
thrpt: [-1.8429% -0.3963% +0.9920%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold. time: [404.31 ms 407.58 ms 410.84 ms]
thrpt: [24.340 Kelem/s 24.535 Kelem/s 24.733 Kelem/s]
change:
time: [-2.2475% -1.1645% -0.0596%] (p = 0.04 < 0.05)
thrpt: [+0.0597% +1.1783% +2.2992%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [46.102 ms 46.808 ms 47.522 ms]
thrpt: [21.043 elem/s 21.364 elem/s 21.691 elem/s]
change:
time: [-1.5447% +0.5442% +2.7916%] (p = 0.62 > 0.05)
thrpt: [-2.7157% -0.5412% +1.5689%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
unwrapcalls when accessing connection IDs.Fixes #1429