Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update env_logger requirement from 0.10 to 0.11 #2036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2024

Updates the requirements on env_logger to permit the latest version.

Release notes

Sourced from env_logger's releases.

v0.11.5

[0.11.5] - 2024-07-25

Changelog

Sourced from env_logger's changelog.

[0.11.5] - 2024-07-25

[0.11.4] - 2024-07-23

[0.11.3] - 2024-03-05

Features

  • Experimental support for key-value logging behind unstable-kv

[0.11.2] - 2024-02-13

[0.11.1] - 2024-01-27

Fixes

  • Allow styling with Target::Pipe

[0.11.0] - 2024-01-19

Migration Guide

env_logger::fmt::Style: The bespoke styling API, behind color, was removed, in favor of accepting any ANSI styled string and adapting it to the target stream's capabilities.

Possible styling libraries include:

  • anstyle is a minimal, runtime string styling API and is re-exported as env_logger::fmt::style
  • owo-colors is a feature rich runtime string styling API
  • color-print for feature-rich compile-time styling API

custom_format.rs uses anstyle via Formatter::default_level_style

Breaking Change

  • Removed bespoke styling API
    • env_logger::fmt::Formatter::style
    • env_logger::fmt::Formatter::default_styled_level
    • env_logger::fmt::Style
    • env_logger::fmt::Color
    • env_logger::fmt::StyledValue
  • Removed env_logger::filter in favor of env_filter

Compatibility

MSRV changed to 1.71

Features

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 5, 2024
@dependabot dependabot bot requested a review from mxinden as a code owner August 5, 2024 08:31
@dependabot dependabot bot added the rust Pull requests that update Rust code label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

  • Linux: Debug Release
  • macOS: Debug Release
  • Windows: Debug Release

Copy link

github-actions bot commented Aug 5, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Aug 5, 2024

Benchmark results

Performance differences relative to 28f60bd.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.299 ns 99.617 ns 99.937 ns]
       change: [-0.6579% -0.0450% +0.4696%] (p = 0.89 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
11 (11.00%) high mild
2 (2.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.23 ns 117.63 ns 118.06 ns]
       change: [-0.3277% +0.1069% +0.5321%] (p = 0.64 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
3 (3.00%) low severe
1 (1.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.74 ns 117.18 ns 117.73 ns]
       change: [-0.6087% +0.0349% +0.6312%] (p = 0.91 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) low severe
4 (4.00%) low mild
3 (3.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.671 ns 97.976 ns 98.366 ns]
       change: [-0.7768% +0.0861% +0.9370%] (p = 0.85 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
5 (5.00%) high mild
7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.47 ms 111.63 ms 111.89 ms]
       change: [-0.6790% -0.5194% -0.2982%] (p = 0.00 < 0.05)

Found 23 outliers among 100 measurements (23.00%)
1 (1.00%) low severe
10 (10.00%) low mild
5 (5.00%) high mild
7 (7.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.414 ms 27.366 ms 28.336 ms]
       change: [-6.1101% -1.0412% +4.4266%] (p = 0.70 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.034 ms 36.644 ms 38.238 ms]
       change: [-9.4597% -4.0955% +2.0868%] (p = 0.19 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [31.105 ms 31.868 ms 32.611 ms]
       change: [-7.1092% -4.4238% -1.3684%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [43.095 ms 46.123 ms 49.137 ms]
       change: [-5.8281% +3.3435% +13.011%] (p = 0.48 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [114.04 ms 114.39 ms 114.74 ms]
       thrpt:  [871.56 MiB/s 874.20 MiB/s 876.91 MiB/s]
change:
       time:   [-1.4291% -0.9010% -0.3621%] (p = 0.00 < 0.05)
       thrpt:  [+0.3634% +0.9092% +1.4498%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [313.78 ms 317.56 ms 321.29 ms]
       thrpt:  [31.124 Kelem/s 31.490 Kelem/s 31.869 Kelem/s]
change:
       time:   [-2.4778% -1.0508% +0.5281%] (p = 0.19 > 0.05)
       thrpt:  [-0.5254% +1.0620% +2.5407%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [32.519 ms 32.695 ms 32.883 ms]
       thrpt:  [30.411  elem/s 30.585  elem/s 30.751  elem/s]
change:
       time:   [-0.0348% +0.5840% +1.2531%] (p = 0.10 > 0.05)
       thrpt:  [-1.2376% -0.5806% +0.0348%]

Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 120.3 ± 61.8 82.3 334.1 1.00
neqo msquic reno on 233.1 ± 61.1 201.0 423.9 1.00
neqo msquic reno 217.2 ± 11.4 206.1 233.4 1.00
neqo msquic cubic on 245.5 ± 82.1 204.2 469.9 1.00
neqo msquic cubic 215.2 ± 11.7 204.4 240.8 1.00
msquic neqo reno on 166.8 ± 124.6 73.8 600.4 1.00
msquic neqo reno 87.6 ± 20.3 73.2 141.0 1.00
msquic neqo cubic on 86.9 ± 29.6 74.8 233.5 1.00
msquic neqo cubic 113.0 ± 60.1 74.6 292.7 1.00
neqo neqo reno on 200.1 ± 82.2 129.0 412.0 1.00
neqo neqo reno 273.8 ± 193.8 140.9 648.3 1.00
neqo neqo cubic on 214.8 ± 96.7 128.0 433.0 1.00
neqo neqo cubic 214.0 ± 105.4 123.1 461.6 1.00

⬇️ Download logs

Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change 0.10 -> 0.11 should not affect neqo.

That said, Firefox build is failing. It complains about multiple env-logger versions in the depedency tree, recommending to upgrade the existing before introducing yet another version:

 0:01.12 E There are 2 different versions of crate env_logger (expected 1). Please avoid the extra duplication or adjust TOLERATED_DUPES in python/mozbuild/mozbuild/vendor/vendor_rust.py if not possible (but we'd prefer the former).

https://searchfox.org/mozilla-central/search?q=env_logger+%3D&path=&case=true&regexp=false

I don't think this is urgent. Thus I am fine waiting. I can also try to push the other users to the new versions if folks would prefer that.

@larseggert
Copy link
Collaborator

Gecko is still at 0.10.0: https://searchfox.org/mozilla-central/source/Cargo.lock#1684

@dependabot dependabot bot force-pushed the dependabot/cargo/env_logger-0.11 branch from 29bbc2a to de61982 Compare August 6, 2024 11:42
@dependabot dependabot bot force-pushed the dependabot/cargo/env_logger-0.11 branch from de61982 to 3aee5ab Compare August 20, 2024 13:11
@dependabot dependabot bot force-pushed the dependabot/cargo/env_logger-0.11 branch from 3aee5ab to 5007101 Compare August 28, 2024 02:21
Updates the requirements on [env_logger](https://github.com/rust-cli/env_logger) to permit the latest version.
- [Release notes](https://github.com/rust-cli/env_logger/releases)
- [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md)
- [Commits](rust-cli/env_logger@v0.10.0...v0.11.5)

---
updated-dependencies:
- dependency-name: env_logger
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/env_logger-0.11 branch from 5007101 to 6fc4a2a Compare September 3, 2024 16:25
@larseggert larseggert added the blocked Blocked on something else label Sep 13, 2024
@larseggert larseggert removed the blocked Blocked on something else label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants