ci: Allow binstall to handle current Rust install issue
#2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 112 112
Lines 36463 36463
=======================================
Hits 34772 34772
Misses 1691 1691 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to ca0080e. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [192.54 ns 192.99 ns 193.51 ns]
change: [-1.7765% -1.0196% -0.4498%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [235.09 ns 235.57 ns 236.11 ns]
change: [-0.5440% +0.3064% +2.0022%] (p = 0.74 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [235.09 ns 235.48 ns 235.98 ns]
change: [-0.9016% -0.4606% -0.0311%] (p = 0.04 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [216.42 ns 216.72 ns 217.07 ns]
change: [-0.5440% +0.1000% +0.8025%] (p = 0.77 > 0.05)
RxStreamOrderer::inbound_frame(): 💚 Performance has improved. time: [118.40 ms 118.47 ms 118.55 ms]
change: [-2.5121% -2.4384% -2.3624%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [39.516 ms 41.274 ms 43.087 ms]
change: [-7.9323% -1.4067% +5.2635%] (p = 0.68 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [56.487 ms 59.645 ms 62.811 ms]
change: [-5.6126% +1.8305% +10.016%] (p = 0.64 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [47.684 ms 49.292 ms 50.867 ms]
change: [-6.1037% -1.4317% +3.1593%] (p = 0.54 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [70.762 ms 77.043 ms 83.267 ms]
change: [-7.0260% +3.7505% +17.144%] (p = 0.54 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [169.92 ms 175.19 ms 182.83 ms]
thrpt: [546.96 MiB/s 570.80 MiB/s 588.50 MiB/s]
change:
time: [-2.3588% +1.0848% +5.6805%] (p = 0.65 > 0.05)
thrpt: [-5.3752% -1.0731% +2.4158%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold. time: [410.24 ms 413.95 ms 417.59 ms]
thrpt: [23.947 Kelem/s 24.157 Kelem/s 24.376 Kelem/s]
change:
time: [+0.1788% +1.3911% +2.5889%] (p = 0.03 < 0.05)
thrpt: [-2.5236% -1.3721% -0.1785%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [45.080 ms 45.785 ms 46.488 ms]
thrpt: [21.511 elem/s 21.841 elem/s 22.183 elem/s]
change:
time: [-4.7095% -2.6185% -0.4357%] (p = 0.02 < 0.05)
thrpt: [+0.4376% +2.6889% +4.9423%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.