fix: qlog reference_time should be in msec
#2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 112 112
Lines 36507 36516 +9
=======================================
+ Hits 34812 34821 +9
Misses 1695 1695 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 16e9085. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [194.37 ns 194.86 ns 195.38 ns]
change: [-1.1688% -0.2217% +0.4022%] (p = 0.68 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [235.92 ns 236.46 ns 237.06 ns]
change: [-0.0321% +0.3044% +0.6810%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [236.05 ns 236.94 ns 238.05 ns]
change: [+0.0166% +0.4428% +0.8819%] (p = 0.05 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [217.03 ns 217.28 ns 217.58 ns]
change: [-0.5083% +0.0933% +0.7003%] (p = 0.77 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [120.02 ms 120.11 ms 120.21 ms]
change: [-0.1866% -0.0808% +0.0276%] (p = 0.15 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [41.954 ms 43.697 ms 45.403 ms]
change: [-3.8558% +1.8751% +8.2069%] (p = 0.53 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [55.258 ms 58.514 ms 61.903 ms]
change: [-5.9713% +1.7965% +10.226%] (p = 0.68 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [48.444 ms 49.960 ms 51.442 ms]
change: [-2.8663% +1.3392% +5.6722%] (p = 0.53 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [70.544 ms 76.952 ms 83.294 ms]
change: [-9.3772% +2.1998% +15.366%] (p = 0.73 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [129.46 ms 130.11 ms 130.78 ms]
thrpt: [764.65 MiB/s 768.59 MiB/s 772.46 MiB/s]
change:
time: [-15.457% -5.4291% +1.5534%] (p = 0.39 > 0.05)
thrpt: [-1.5296% +5.7408% +18.284%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [408.46 ms 411.53 ms 414.60 ms]
thrpt: [24.120 Kelem/s 24.300 Kelem/s 24.482 Kelem/s]
change:
time: [-0.3405% +0.8165% +1.9545%] (p = 0.15 > 0.05)
thrpt: [-1.9171% -0.8099% +0.3417%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [46.372 ms 47.119 ms 47.873 ms]
thrpt: [20.889 elem/s 21.223 elem/s 21.565 elem/s]
change:
time: [-1.7166% +0.3146% +2.5487%] (p = 0.78 > 0.05)
thrpt: [-2.4854% -0.3136% +1.7466%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Aug 13, 2024
Co-authored-by: Max Inden <mail@max-inden.de> Signed-off-by: Lars Eggert <lars@eggert.org>
|
I can try whether we can replace all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/html/draft-ietf-quic-qlog-main-schema#section-7.1