chore: Switch to the windows crate
#2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `winapi` isn't being updated anymore, and the `windows` crate is a more modern alternative maintained by Microsoft.
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
- Coverage 95.36% 95.32% -0.04%
==========================================
Files 112 112
Lines 36505 36505
==========================================
- Hits 34813 34800 -13
- Misses 1692 1705 +13 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 910a7cd. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.057 ns 99.342 ns 99.635 ns]
change: [-1.0813% -0.5838% -0.1056%] (p = 0.02 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.29 ns 117.67 ns 118.10 ns]
change: [-2.0256% -1.0717% -0.2868%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.67 ns 117.07 ns 117.56 ns]
change: [-1.8584% -1.0156% -0.0134%] (p = 0.02 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.337 ns 97.460 ns 97.601 ns]
change: [-3.0272% -1.8988% -0.7253%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.31 ms 111.46 ms 111.69 ms]
change: [-0.4446% -0.2972% -0.0986%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.208 ms 28.134 ms 29.068 ms]
change: [-3.2651% +1.6359% +6.8388%] (p = 0.52 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.880 ms 36.515 ms 38.119 ms]
change: [-4.9125% +1.3596% +7.6687%] (p = 0.68 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.622 ms 32.414 ms 33.173 ms]
change: [-3.2744% -0.0511% +3.1933%] (p = 0.97 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [44.794 ms 47.699 ms 50.602 ms]
change: [-1.8716% +6.5688% +16.179%] (p = 0.15 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💔 Performance has regressed. time: [115.57 ms 115.99 ms 116.40 ms]
thrpt: [859.13 MiB/s 862.13 MiB/s 865.28 MiB/s]
change:
time: [+1.0657% +1.5701% +2.0963%] (p = 0.00 < 0.05)
thrpt: [-2.0532% -1.5458% -1.0544%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.40 ms 314.02 ms 317.68 ms]
thrpt: [31.478 Kelem/s 31.845 Kelem/s 32.216 Kelem/s]
change:
time: [-1.5959% +0.0734% +1.6924%] (p = 0.93 > 0.05)
thrpt: [-1.6643% -0.0734% +1.6217%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [40.340 ms 41.059 ms 41.788 ms]
thrpt: [23.930 elem/s 24.355 elem/s 24.789 elem/s]
change:
time: [-2.5539% -0.1723% +2.4109%] (p = 0.89 > 0.05)
thrpt: [-2.3541% +0.1726% +2.6208%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
👍 For the record, the |
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
approved these changes
Aug 27, 2024
martinthomson
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
winapicrate isn't being updated anymore, and thewindowscrate is a more modern alternative maintained by Microsoft.