chore: prepare v0.9.0 release #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 112 112
Lines 36505 36530 +25
=======================================
+ Hits 34813 34837 +24
- Misses 1692 1693 +1 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 6f8823b. coalesce_acked_from_zero 1+1 entries: 💔 Performance has regressed. time: [99.768 ns 100.02 ns 100.28 ns]
change: [+1.2109% +2.0523% +3.3251%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.57 ns 117.88 ns 118.22 ns]
change: [+0.1158% +0.5003% +0.8455%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.39 ns 117.71 ns 118.13 ns]
change: [+0.5723% +1.0867% +1.6615%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.470 ns 97.719 ns 98.078 ns]
change: [-0.9709% +0.3020% +1.5586%] (p = 0.67 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.79 ms 111.84 ms 111.89 ms]
change: [+0.2269% +0.2918% +0.3592%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.726 ms 27.711 ms 28.713 ms]
change: [-2.4264% +3.0112% +8.3027%] (p = 0.26 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [36.749 ms 38.326 ms 39.930 ms]
change: [-2.2679% +3.9296% +10.833%] (p = 0.23 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.992 ms 32.712 ms 33.401 ms]
change: [-4.7273% -1.9137% +0.9141%] (p = 0.19 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.320 ms 44.184 ms 47.036 ms]
change: [-14.959% -6.8730% +1.1964%] (p = 0.12 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.91 ms 114.20 ms 114.48 ms]
thrpt: [873.54 MiB/s 875.67 MiB/s 877.89 MiB/s]
change:
time: [-1.2071% -0.7687% -0.3058%] (p = 0.00 < 0.05)
thrpt: [+0.3068% +0.7746% +1.2218%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [315.84 ms 319.64 ms 323.35 ms]
thrpt: [30.926 Kelem/s 31.285 Kelem/s 31.661 Kelem/s]
change:
time: [-0.6559% +1.0770% +2.8009%] (p = 0.22 > 0.05)
thrpt: [-2.7246% -1.0655% +0.6603%]
1-conn/1-1b-resp (aka. HPS)/client: 💚 Performance has improved. time: [32.520 ms 32.671 ms 32.832 ms]
thrpt: [30.458 elem/s 30.608 elem/s 30.751 elem/s]
change:
time: [-21.052% -19.662% -18.201%] (p = 0.00 < 0.05)
thrpt: [+22.251% +24.475% +26.666%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
|
I keep hoping that Marten merges my QNS patch, so I can finally fix the 0-RTT PR and merge it. I will switch CI to my own QNS docker image next week if that still hasn't happened. I'd be nice if those fixes made it into a release soon, too. |
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
👍 happy to cut another release, once this is ready. |
KershawChang
approved these changes
Sep 3, 2024
|
For the record, mozilla-central now uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to bring #2072 to mozilla-central to be used in phabricator#D220062 to enable Fast UDP for Firefox - milestone 2 - ECN support.
Let's wait for #2081 to merge first though.Anything else? Any objections?
As always, given that cutting a Neqo release and landing it in mozilla-central is easy, I suggest blocking Neqo releases on bug fixes only.