Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump martenseemann/quic-network-simulator-endpoint from 5114afe to 5177120 in /qns #2084

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2024

Bumps martenseemann/quic-network-simulator-endpoint from 5114afe to 5177120.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps martenseemann/quic-network-simulator-endpoint from `5114afe` to `5177120`.

---
updated-dependencies:
- dependency-name: martenseemann/quic-network-simulator-endpoint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 2, 2024
@dependabot dependabot bot added the docker Pull requests that update Docker code label Sep 2, 2024
@mxinden
Copy link
Collaborator

mxinden commented Sep 2, 2024

Is this related to quic-interop/quic-network-simulator#133?

@larseggert
Copy link
Collaborator

No, this is from our regular two-week dependabot workflow that tracks changes to your base image. I think it's quic-interop/quic-network-simulator#134 that is being pulled in by this.

Copy link

github-actions bot commented Sep 2, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert merged commit 7139f57 into main Sep 2, 2024
50 of 55 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/martenseemann/quic-network-simulator-endpoint-517712019dda2a4d6f39e4490a55f29eae7ba415624067efe749f896e577ea91 branch September 2, 2024 09:24
Copy link

github-actions bot commented Sep 2, 2024

Benchmark results

Performance differences relative to 6f8823b.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [99.371 ns 99.736 ns 100.10 ns]
       change: [+0.5094% +0.9861% +1.5313%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
12 (12.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [118.11 ns 118.51 ns 118.93 ns]
       change: [+0.4681% +0.8790% +1.2794%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
1 (1.00%) low severe
1 (1.00%) high mild
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [117.63 ns 118.08 ns 118.62 ns]
       change: [+0.5517% +1.0388% +1.5159%] (p = 0.00 < 0.05)

Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) low severe
1 (1.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.410 ns 98.550 ns 98.702 ns]
       change: [-0.3414% +0.8829% +2.1241%] (p = 0.16 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [112.00 ms 112.06 ms 112.11 ms]
       change: [+0.4126% +0.4828% +0.5583%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.919 ms 27.806 ms 28.695 ms]
       change: [-1.5639% +3.3621% +8.2417%] (p = 0.18 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) low mild
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.558 ms 37.141 ms 38.764 ms]
       change: [-5.5023% +0.7146% +7.5227%] (p = 0.83 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.974 ms 32.645 ms 33.308 ms]
       change: [-4.8528% -2.1145% +0.6818%] (p = 0.14 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [42.134 ms 44.645 ms 47.152 ms]
       change: [-13.058% -5.9014% +2.0480%] (p = 0.15 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [113.19 ms 113.51 ms 113.83 ms]
       thrpt:  [878.47 MiB/s 881.00 MiB/s 883.48 MiB/s]
change:
       time:   [-1.8250% -1.3687% -0.8942%] (p = 0.00 < 0.05)
       thrpt:  [+0.9023% +1.3877% +1.8589%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [310.72 ms 314.19 ms 317.60 ms]
       thrpt:  [31.486 Kelem/s 31.828 Kelem/s 32.183 Kelem/s]
change:
       time:   [-2.2743% -0.6468% +0.9742%] (p = 0.44 > 0.05)
       thrpt:  [-0.9648% +0.6511% +2.3272%]
1-conn/1-1b-resp (aka. HPS)/client: 💚 Performance has improved.
       time:   [32.735 ms 32.928 ms 33.137 ms]
       thrpt:  [30.177  elem/s 30.369  elem/s 30.548  elem/s]
change:
       time:   [-20.473% -19.031% -17.525%] (p = 0.00 < 0.05)
       thrpt:  [+21.249% +23.504% +25.744%]

Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 95.3 ± 20.8 83.4 166.1 1.00
neqo msquic reno on 216.3 ± 10.7 206.0 240.0 1.00
neqo msquic reno 219.4 ± 11.6 203.2 240.6 1.00
neqo msquic cubic on 218.4 ± 12.9 202.6 239.1 1.00
neqo msquic cubic 216.0 ± 10.8 203.8 240.2 1.00
msquic neqo reno on 84.9 ± 12.4 73.9 113.1 1.00
msquic neqo reno 87.2 ± 17.5 73.8 154.1 1.00
msquic neqo cubic on 87.2 ± 24.1 73.6 171.0 1.00
msquic neqo cubic 93.4 ± 24.3 74.0 172.6 1.00
neqo neqo reno on 202.9 ± 120.1 121.9 484.2 1.00
neqo neqo reno 165.5 ± 59.1 129.7 400.7 1.00
neqo neqo cubic on 187.4 ± 64.3 127.7 312.0 1.00
neqo neqo cubic 158.1 ± 28.2 122.6 229.5 1.00

⬇️ Download logs

Copy link

github-actions bot commented Sep 2, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants