ci: Try and speed up QNS docker build #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 95.36% 95.30% -0.07%
==========================================
Files 112 112
Lines 36559 36300 -259
==========================================
- Hits 34866 34596 -270
- Misses 1693 1704 +11 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 28f60bd. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.501 ns 99.825 ns 100.15 ns]
change: [-0.0318% +0.9025% +2.0566%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.55 ns 117.86 ns 118.21 ns]
change: [+0.0609% +0.5464% +1.0336%] (p = 0.03 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.10 ns 117.53 ns 118.05 ns]
change: [-0.3541% +0.2385% +0.7407%] (p = 0.42 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.359 ns 97.485 ns 97.624 ns]
change: [-0.9854% -0.1336% +0.7523%] (p = 0.78 > 0.05)
RxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [114.34 ms 114.48 ms 114.70 ms]
change: [+1.8791% +2.0130% +2.2322%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.657 ms 28.766 ms 29.879 ms]
change: [-1.7747% +4.0209% +9.9170%] (p = 0.16 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.027 ms 36.914 ms 38.829 ms]
change: [-9.6250% -3.3887% +3.1849%] (p = 0.33 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [32.401 ms 33.126 ms 33.832 ms]
change: [-3.6098% -0.6507% +2.2954%] (p = 0.67 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [43.101 ms 46.435 ms 49.763 ms]
change: [-5.2877% +4.0434% +13.706%] (p = 0.42 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [112.43 ms 112.92 ms 113.39 ms]
thrpt: [881.91 MiB/s 885.55 MiB/s 889.42 MiB/s]
change:
time: [-2.7566% -2.1719% -1.5715%] (p = 0.00 < 0.05)
thrpt: [+1.5966% +2.2202% +2.8347%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [314.75 ms 318.35 ms 321.87 ms]
thrpt: [31.069 Kelem/s 31.412 Kelem/s 31.771 Kelem/s]
change:
time: [-2.2649% -0.8060% +0.7471%] (p = 0.30 > 0.05)
thrpt: [-0.7416% +0.8125% +2.3174%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [32.357 ms 32.536 ms 32.728 ms]
thrpt: [30.555 elem/s 30.735 elem/s 30.905 elem/s]
change:
time: [-0.5576% +0.0954% +0.8360%] (p = 0.78 > 0.05)
thrpt: [-0.8291% -0.0953% +0.5607%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Sep 9, 2024
Co-authored-by: Max Inden <mail@max-inden.de> Signed-off-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via https://github.com/LukeMathWalker/cargo-chef