test(transport): check local and remote GREASE_QUIC_BIT TP #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Sep 12, 2024
|
Thanks, we can land this after #2100. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 95.35% 95.38% +0.02%
==========================================
Files 112 112
Lines 36325 36325
==========================================
+ Hits 34638 34647 +9
+ Misses 1687 1678 -9 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 0b106c2. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.351 ns 99.683 ns 100.02 ns]
change: [-0.1542% +0.6098% +1.5340%] (p = 0.17 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.23 ns 117.56 ns 117.92 ns]
change: [-0.0962% +0.3521% +0.8000%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.98 ns 118.23 ns 120.34 ns]
change: [+0.0235% +1.0363% +2.4624%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.378 ns 97.571 ns 97.807 ns]
change: [-1.0251% -0.1066% +0.8405%] (p = 0.83 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.47 ms 112.61 ms 112.83 ms]
change: [+0.9661% +1.1095% +1.3312%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.839 ms 26.842 ms 27.841 ms]
change: [-9.2546% -4.2640% +0.6030%] (p = 0.10 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.514 ms 36.361 ms 38.253 ms]
change: [-5.6946% +0.5461% +7.4262%] (p = 0.88 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.305 ms 32.021 ms 32.727 ms]
change: [-5.1059% -2.2080% +0.9687%] (p = 0.17 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [38.192 ms 40.661 ms 43.139 ms]
change: [-18.383% -10.608% -1.9496%] (p = 0.02 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.08 ms 113.54 ms 114.04 ms]
thrpt: [876.90 MiB/s 880.77 MiB/s 884.31 MiB/s]
change:
time: [-1.8711% -1.3187% -0.7524%] (p = 0.00 < 0.05)
thrpt: [+0.7581% +1.3363% +1.9068%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [312.60 ms 316.45 ms 320.33 ms]
thrpt: [31.218 Kelem/s 31.600 Kelem/s 31.990 Kelem/s]
change:
time: [-2.2632% -0.6558% +1.0318%] (p = 0.45 > 0.05)
thrpt: [-1.0213% +0.6601% +2.3156%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.948 ms 34.124 ms 34.316 ms]
thrpt: [29.141 elem/s 29.305 elem/s 29.456 elem/s]
change:
time: [-0.9045% -0.0607% +0.7617%] (p = 0.89 > 0.05)
thrpt: [-0.7559% +0.0608% +0.9127%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2100.
Test succeeds when run on top of #2100.
@larseggert feel free to cherry-pick in case you find this useful.