Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump martenseemann/quic-network-simulator-endpoint from f65a034 to 42d79cc in /qns #2111

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps martenseemann/quic-network-simulator-endpoint from f65a034 to 42d79cc.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps martenseemann/quic-network-simulator-endpoint from `f65a034` to `42d79cc`.

---
updated-dependencies:
- dependency-name: martenseemann/quic-network-simulator-endpoint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 16, 2024
@dependabot dependabot bot added the docker Pull requests that update Docker code label Sep 16, 2024
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert merged commit 9dd05bb into main Sep 16, 2024
54 of 55 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/martenseemann/quic-network-simulator-endpoint-42d79cc04b88f2e4b4c8beb418b0843c123f26852ff6bbba4caa6badc0043d23 branch September 16, 2024 09:13
Copy link

Benchmark results

Performance differences relative to 259a15f.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.394 ns 99.727 ns 100.09 ns]
       change: [-0.4503% +0.0025% +0.4655%] (p = 0.99 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.24 ns 117.48 ns 117.77 ns]
       change: [-0.7820% -0.2474% +0.2075%] (p = 0.37 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
3 (3.00%) low mild
4 (4.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.90 ns 117.22 ns 117.63 ns]
       change: [-0.6077% +0.0533% +0.7923%] (p = 0.89 > 0.05)

Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) low severe
1 (1.00%) low mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.532 ns 97.704 ns 97.908 ns]
       change: [-0.8571% -0.0391% +0.8073%] (p = 0.93 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
3 (3.00%) high mild
10 (10.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.54 ms 111.60 ms 111.65 ms]
       change: [+0.0071% +0.0760% +0.1498%] (p = 0.04 < 0.05)

Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low severe
6 (6.00%) low mild
6 (6.00%) high mild
3 (3.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.220 ms 27.190 ms 28.186 ms]
       change: [-6.7187% -1.6363% +3.5778%] (p = 0.53 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.515 ms 35.865 ms 37.225 ms]
       change: [-8.5138% -3.2057% +2.6251%] (p = 0.29 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [30.219 ms 30.968 ms 31.695 ms]
       change: [-7.9119% -4.5174% -1.0892%] (p = 0.01 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.005 ms 42.783 ms 45.522 ms]
       change: [-7.9496% +1.6217% +12.399%] (p = 0.74 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.62 ms 114.12 ms 114.61 ms]
       thrpt:  [872.49 MiB/s 876.25 MiB/s 880.16 MiB/s]
change:
       time:   [-0.0485% +0.5817% +1.2619%] (p = 0.08 > 0.05)
       thrpt:  [-1.2462% -0.5783% +0.0485%]

Found 6 outliers among 100 measurements (6.00%)
5 (5.00%) low mild
1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [313.51 ms 317.30 ms 321.05 ms]
       thrpt:  [31.148 Kelem/s 31.516 Kelem/s 31.897 Kelem/s]
change:
       time:   [-1.5023% +0.0429% +1.6771%] (p = 0.96 > 0.05)
       thrpt:  [-1.6494% -0.0428% +1.5252%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [34.030 ms 34.212 ms 34.411 ms]
       thrpt:  [29.061  elem/s 29.230  elem/s 29.386  elem/s]
change:
       time:   [-0.6261% +0.2644% +1.0889%] (p = 0.54 > 0.05)
       thrpt:  [-1.0771% -0.2637% +0.6301%]

Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) high mild
5 (5.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 100.6 ± 17.9 90.5 182.9 1.00
neqo msquic reno on 218.6 ± 12.2 201.6 239.8 1.00
neqo msquic reno 227.0 ± 13.3 207.1 244.9 1.00
neqo msquic cubic on 308.3 ± 138.5 203.3 596.0 1.00
neqo msquic cubic 218.3 ± 13.2 203.1 241.4 1.00
msquic neqo reno on 92.0 ± 16.6 81.1 163.6 1.00
msquic neqo reno 104.1 ± 22.2 81.3 161.9 1.00
msquic neqo cubic on 101.8 ± 21.4 82.1 153.1 1.00
msquic neqo cubic 94.2 ± 21.3 81.9 155.8 1.00
neqo neqo reno on 192.0 ± 99.7 123.2 447.8 1.00
neqo neqo reno 161.9 ± 65.1 129.3 396.6 1.00
neqo neqo cubic on 165.9 ± 44.1 125.1 329.0 1.00
neqo neqo cubic 176.3 ± 59.6 122.6 346.1 1.00

⬇️ Download logs

Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant