ci: Unpin Rust nightly #2112
Merged
ci: Unpin Rust nightly #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
- Coverage 95.35% 95.34% -0.01%
==========================================
Files 112 112
Lines 36319 36319
==========================================
- Hits 34631 34630 -1
- Misses 1688 1689 +1 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 9dd05bb. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.092 ns 99.972 ns 101.37 ns]
change: [-0.7550% -0.1539% +0.4963%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.79 ns 117.20 ns 117.63 ns]
change: [-0.4106% -0.0863% +0.2451%] (p = 0.61 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.34 ns 116.74 ns 117.25 ns]
change: [-0.4531% +0.1363% +0.8488%] (p = 0.70 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.991 ns 98.168 ns 98.363 ns]
change: [-0.3309% +0.5610% +1.4002%] (p = 0.22 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.37 ms 112.42 ms 112.47 ms]
change: [+0.6979% +0.7648% +0.8297%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.450 ms 27.310 ms 28.157 ms]
change: [-4.9239% -0.4571% +4.2385%] (p = 0.85 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.174 ms 36.752 ms 38.344 ms]
change: [-5.2899% +0.8439% +7.6165%] (p = 0.80 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [30.998 ms 31.752 ms 32.475 ms]
change: [-4.4972% -1.6273% +1.3848%] (p = 0.29 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [38.748 ms 41.781 ms 44.788 ms]
change: [-8.9176% +0.3342% +10.951%] (p = 0.94 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [112.76 ms 113.26 ms 113.73 ms]
thrpt: [879.28 MiB/s 882.91 MiB/s 886.85 MiB/s]
change:
time: [-2.3260% -1.7653% -1.3249%] (p = 0.00 < 0.05)
thrpt: [+1.3427% +1.7971% +2.3814%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold. time: [309.95 ms 313.31 ms 316.70 ms]
thrpt: [31.575 Kelem/s 31.917 Kelem/s 32.264 Kelem/s]
change:
time: [-3.1867% -1.6436% -0.1180%] (p = 0.04 < 0.05)
thrpt: [+0.1181% +1.6710% +3.2916%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.966 ms 34.155 ms 34.360 ms]
thrpt: [29.104 elem/s 29.278 elem/s 29.442 elem/s]
change:
time: [-1.0168% -0.2762% +0.5311%] (p = 0.49 > 0.05)
thrpt: [-0.5283% +0.2770% +1.0272%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.