fix: Don't pace during QNS zerortt test
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we pace, we might get the initial server flight before sending sufficient 0-RTT data to pass the QNS check. Broken out of mozilla#1998
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
- Coverage 95.35% 95.31% -0.04%
==========================================
Files 112 112
Lines 36319 36319
==========================================
- Hits 34631 34619 -12
- Misses 1688 1700 +12 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 9dd05bb. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.184 ns 99.523 ns 99.866 ns]
change: [-0.5691% -0.0382% +0.4864%] (p = 0.89 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.15 ns 117.54 ns 117.94 ns]
change: [-0.1556% +0.1648% +0.4862%] (p = 0.31 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.53 ns 116.83 ns 117.26 ns]
change: [-0.5048% -0.1927% +0.0786%] (p = 0.21 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.033 ns 98.189 ns 98.363 ns]
change: [-0.6225% +0.2240% +1.0811%] (p = 0.63 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.65 ms 111.78 ms 112.00 ms]
change: [+0.0572% +0.1948% +0.3750%] (p = 0.01 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.250 ms 28.215 ms 29.181 ms]
change: [-2.1977% +2.8410% +7.9669%] (p = 0.27 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.005 ms 36.535 ms 38.089 ms]
change: [-5.9771% +0.2472% +6.6937%] (p = 0.94 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.844 ms 32.643 ms 33.436 ms]
change: [-1.7928% +1.1342% +4.1739%] (p = 0.49 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.595 ms 42.414 ms 45.264 ms]
change: [-7.8411% +1.8554% +12.119%] (p = 0.70 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [112.61 ms 113.37 ms 114.12 ms]
thrpt: [876.30 MiB/s 882.03 MiB/s 887.99 MiB/s]
change:
time: [-2.4032% -1.6667% -1.0315%] (p = 0.00 < 0.05)
thrpt: [+1.0423% +1.6950% +2.4624%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [313.94 ms 317.76 ms 321.55 ms]
thrpt: [31.099 Kelem/s 31.470 Kelem/s 31.854 Kelem/s]
change:
time: [-1.8871% -0.2460% +1.3311%] (p = 0.77 > 0.05)
thrpt: [-1.3136% +0.2466% +1.9234%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.844 ms 34.042 ms 34.256 ms]
thrpt: [29.192 elem/s 29.375 elem/s 29.547 elem/s]
change:
time: [-1.4024% -0.6071% +0.1784%] (p = 0.14 > 0.05)
thrpt: [-0.1781% +0.6108% +1.4224%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we pace, we might get the initial server flight before sending sufficient 0-RTT data to pass the QNS check.
Broken out of #1998